Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition started and finished callbacks #16

Closed
guvenakcoban opened this issue Sep 27, 2020 · 6 comments · Fixed by #57
Closed

Transition started and finished callbacks #16

guvenakcoban opened this issue Sep 27, 2020 · 6 comments · Fixed by #57
Labels
feature request

Comments

@guvenakcoban
Copy link

I use the Transition component for my custom modal and I need to clear the component state when the modal completely is hidden.

onEnterStarted, onEnterFinished, onLeaveStarted, onLeaveFinished methods could be a nice feature!
@ThiagoFelippi
Copy link

I could implement this?

@RobinMalfait
Copy link
Member

Hey! Thank you for your feature suggestion!
Much appreciated! 🙏

We will expose some events, but probably not all. I'll link to this issue when I open a PR!

@RobinMalfait RobinMalfait mentioned this issue Oct 6, 2020
Merged
@RobinMalfait
Copy link
Member

Hey @guvenakcoban I've opened a PR here: #57 what do you think?

@guvenakcoban
Copy link
Author

guvenakcoban commented Oct 7, 2020 •
edited
Loading

@RobinMalfait Looks good! Thanks for that amazing package.

@tgroshon
Copy link

tgroshon commented Dec 29, 2020 •
edited
Loading

It looks like this got merged to develop but never released? I don't see any of the relevant code in the actual source published on NPM.

@RobinMalfait
Copy link
Member

Correct, didn't write the docs for it yet. You can test it out using the dev build @headlessui/react@dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Transition events tailwindlabs/headlessui
4 participants
@tgroshon @RobinMalfait @guvenakcoban @ThiagoFelippi