Skip to content

Commit 124d543

Browse files
Don't create rule that would repeated built-in rule
1 parent 32de423 commit 124d543

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

integrations/upgrade/js-config.test.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1436,7 +1436,7 @@ describe('border compatibility', () => {
14361436
},
14371437
)
14381438

1439-
test.only(
1439+
test(
14401440
'migrates `container` component configurations',
14411441
{
14421442
fs: {
@@ -1491,23 +1491,21 @@ describe('border compatibility', () => {
14911491
@utility container {
14921492
margin-inline: auto;
14931493
padding-inline: 2rem;
1494-
@media (width >= theme(--breakpoint-2xl)) {
1495-
padding-inline: 4rem;
1496-
}
14971494
@media (width >= theme(--breakpoint-sm)) {
1498-
padding-inline: none;
1495+
max-width: none;
14991496
}
15001497
@media (width >= theme(--breakpoint-md)) {
1501-
padding-inline: none;
1498+
max-width: none;
15021499
}
15031500
@media (width >= theme(--breakpoint-lg)) {
1504-
padding-inline: none;
1501+
max-width: none;
15051502
}
15061503
@media (width >= theme(--breakpoint-xl)) {
1507-
padding-inline: 1280px;
1504+
max-width: 1280px;
15081505
}
15091506
@media (width >= theme(--breakpoint-2xl)) {
1510-
padding-inline: 1536px;
1507+
max-width: 1536px;
1508+
padding-inline: 4rem;
15111509
}
15121510
}
15131511

packages/tailwindcss/src/compat/container-config.test.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -200,10 +200,10 @@ test('allows breakpoints to be overwritten', async () => {
200200
max-width: none;
201201
}
202202
@media (width >= 80rem) {
203-
max-width: 1280px;
203+
max-width: var(--breakpoint-xl);
204204
}
205205
@media (width >= 96rem) {
206-
max-width: 1536px;
206+
max-width: var(--breakpoint-2xl);
207207
}
208208
}
209209
"
@@ -294,6 +294,7 @@ test('combines custom padding and screen overwrites', async () => {
294294
'2xl': '4rem',
295295
},
296296
screens: {
297+
md: '48rem',
297298
xl: '1280px',
298299
'2xl': '1536px',
299300
},
@@ -336,17 +337,14 @@ test('combines custom padding and screen overwrites', async () => {
336337
@media (width >= 40rem) {
337338
max-width: none;
338339
}
339-
@media (width >= 48rem) {
340-
max-width: none;
341-
}
342340
@media (width >= 64rem) {
343341
max-width: none;
344342
}
345343
@media (width >= 80rem) {
346-
max-width: 1280px;
344+
max-width: var(--breakpoint-xl);
347345
}
348346
@media (width >= 96rem) {
349-
max-width: 1536px;
347+
max-width: var(--breakpoint-2xl);
350348
padding-inline: 4rem;
351349
}
352350
}

packages/tailwindcss/src/compat/container.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,11 @@ export function buildCustomContainerUtilityRules(
5858
}
5959

6060
for (let [key, value] of Object.entries(screens)) {
61-
breakpointOverwrites.set(key, [decl('max-width', value)])
61+
let coreBreakpoint = breakpoints.find(([k]) => k === key)
62+
if (coreBreakpoint && value === coreBreakpoint[1]) {
63+
continue
64+
}
65+
breakpointOverwrites.set(key, [decl('max-width', `var(--breakpoint-${key})`)])
6266
}
6367
}
6468

0 commit comments

Comments
 (0)