Dark mode `class` strategy not compatible with complex variants like `group-hover` #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

adamwathan opened this issue Sep 6, 2020 · 0 comments · Fixed by #2337

Member

adamwathan commented Sep 6, 2020

Using the dark mode stuff in class mode with group-hover enabled generates selectors like this:

.dark .dark\:group:hover .dark .dark\:group-hover\:bg-white

...which seems pretty wrong.

I think the correct output should be this:

.dark .group:hover .dark\:group-hover\:bg-white

The text was updated successfully, but these errors were encountered:

adamwathan mentioned this issue

Fix issue where dark variant in 'class' mode was incompatible with 'group-hover' variant #2337

Merged

adamwathan closed this as completed in #2337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment