Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Consolidate UI layouts #10

Open
olivierobert opened this issue Nov 28, 2023 · 0 comments · Fixed by #16
Open

[Chore] Consolidate UI layouts #10

olivierobert opened this issue Nov 28, 2023 · 0 comments · Fixed by #16

Comments

@olivierobert
Copy link

Issue

The current views contain much duplicated code (head + body) and are not consistent. For instance, https://github.com/tajul-saajan/google-searcher/blob/main/resources/views/home.hbs seems to se template.hbs but https://github.com/tajul-saajan/google-searcher/blob/main/resources/views/details.hbs does not.

Expected

All views should inherit from a template. Since there are two main areas (non-authenticated pages and authenticated ones), there could be two main templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant