Tajul/improve google searcher #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jan/google-searcher into tajul/improve-google-searcher # Conflicts: # package-lock.json # package.json
tajul-saajan
changed the base branch from
main
to
tajul/keyword-async-processing
…an/google-searcher into tajul/consolidate-ui-layouts
…n/google-searcher into tajul/test-coverage
olivierobert
reviewed
Dec 4, 2023
There was a problem hiding this comment.
The implementation is an improvement. Still, this could be improved further by splitting the fetching logic from the parsing one. Axios and Cheerio could be passed as dependencies via Dependency Injection (DI) making the swap to different fetcher and parser possible.
Tajul/test coverage
Tajul/consolidate UI layouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #11
enclosed the calculations of different variables in functions inside the page.evaluate
used tags, ids as constants