Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder not found #13

Open
delanym opened this issue Dec 30, 2020 · 4 comments
Open

Builder not found #13

delanym opened this issue Dec 30, 2020 · 4 comments

Comments

@delanym
Copy link

delanym commented Dec 30, 2020

When I run

mvn clean install -T2 -b smart

I get this error

The builder requested using id = smart cannot be found

Apache Maven 3.6.3
Maven home: /usr/share/maven
Java version: 1.8.0_275, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_ZA, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-58-generic", arch: "amd64", family: "unix"

/etc/maven/lib/ext
├── synchronized-resolver-3.2.5.jar
├── takari-filemanager-0.8.3.jar
├── takari-local-repository-0.11.3.jar
└── takari-smart-builder-0.6.1.jar
@delanym
Copy link
Author

delanym commented Jan 5, 2021

I also don't see a timing file created in ${maven.multiModuleProjectDirectory}/.mvn/
How do I verify that the extension was invoked? I don't see any documentation on configuring this other than http://takari.io/book/30-team-maven.html#using-team

@mlosicki
Copy link

mlosicki commented Jan 5, 2021

I also tried executing this extension and creating an extensions.xml file in the .mvn directory that you mentioned worked out of the box for me.

<extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
            xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd">
    <extension>
        <groupId>io.takari.maven</groupId>
        <artifactId>takari-smart-builder</artifactId>
        <version>0.6.1</version>
    </extension>
</extensions>

If you execute with -X, you should see those jars mentioned right at the start of the build.
The timing.properties file was removed in 3f813eb

@delanym
Copy link
Author

delanym commented Jan 5, 2021

I can include any JAR in the classpath - it doesn't mean the routines are necessarily active in my build.
When I run multi-thread build the log indicates this with "Using the MultiThreadedBuilder implementation with a thread count of 3"
When I run other extensions they indicate their activation (not other Takari extensions though)

[INFO] BuildTimeEventSpy is registered.
[WARNING] SystemTray is not supported, skipping notifications...
[INFO] Scanning for projects...
[INFO] gitflow-incremental-builder 3.12.1 starting...

The reason I'm suspicious of this extension is the lack of interest in it, it has no configurable parameters, it doesn't register with the builder interface switch '--builder' which the documentation instructs me to use, and its replacing default Maven functionality. How do I know that its playing nicely with the above MultiThreadedBuilder and gitflow-incremental-builder?

I compared the reactor order of projects with and without the extension, and they are identical. In a reactor of over 500 projects I expect at least something to change when critical path scheduling is applied.

@cstamas
Copy link
Member

cstamas commented Sep 11, 2024

I cannot reproduce this when smart-builder installed according to documentation in README:
https://github.com/takari/takari-smart-builder/blob/master/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants