-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create KernelTypeApp application #45
Comments
Actually, maybe we want both Kernel types in general can't be created by a set command, because it's up to kernel providers how they are defined. So the only things we can do with kernel types in general are list them, and launch instances from them. Maybe the The subset of kernel types defined by kernel specs are something we know how to create and delete, in contrast. So the interface for this should still refer to kernelspecs. Sorry, I had forgotten what the commands did. |
Yes, every provider should provide a means of creating the discoverable entity. I suppose for some, that may not be applicable. Also, there could be some providers whose consumable entity is completely virtual and will rely on the launch parameters to "configure" the "kernel specification" on the fly. I see either side. KernelTypeApp or KernelSpecApp for creating the entity. I chose the former simply to retain the ability for juypter_client's If we take the approach of using Regarding proliferation, I'm all for reducing it. I do see a need to be able to list available entities across providers. Perhaps kernelTypeApp is solely for listing things? KernelSpecApp (or whatever the thing is that creates specs for KernelSpecProvider) would also provide a list option (as should all provider-specific apps) that would then include the directory where the xxxkernel.json file is located - since that's important for troubleshooting. Thoughts? |
We need to create an equivalent to KernelSpecApp. We should call it KernelTypeApp for two reasons:
The text was updated successfully, but these errors were encountered: