Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the Retrier tests are still randomly failing on ubuntu-latest #193

Closed
sr-gi opened this issue Feb 20, 2023 · 1 comment · Fixed by #194
Closed

Some of the Retrier tests are still randomly failing on ubuntu-latest #193

sr-gi opened this issue Feb 20, 2023 · 1 comment · Fixed by #194
Labels
tests Issues related with test functionality

Comments

@sr-gi
Copy link
Member

sr-gi commented Feb 20, 2023

The Retrier has some tests that are built with fixed waits to give it time to retry, however, every now and then some of them fail given the Retrier hasn't had enough time to make the state transitions.

I think we did a pretty good job narrowing down the times in #184 @mariocynicys, however, looks like it was not fault-proof.

e.g:

https://github.com/talaia-labs/rust-teos/actions/runs/4222411593/jobs/7330883278

@sr-gi sr-gi added the tests Issues related with test functionality label Feb 20, 2023
@sr-gi sr-gi linked a pull request Feb 23, 2023 that will close this issue
@mariocynicys
Copy link
Collaborator

To document: somebody was able to repro these failed tests for more than one time consecutively, It's weird though that the same exact 4 tests fail together (or pass together).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues related with test functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants