Add option suppress_default_hovertext for plot_method = "ggplot" #301

mcsimenc · 2023-12-22T23:44:57Z

closes #300

alanocallaghan

Braces and logical comments apply to other parts of the diff too

Would suggest that this should also work with plot method set to plotly

alanocallaghan · 2023-12-23T00:19:02Z

R/heatmaply.R

@@ -887,6 +890,7 @@ heatmaply.heatmapr <- function(x,
                               point_size_name = "Point size",
                               label_format_fun = function(...) format(..., digits = 4),
                               custom_hovertext = x[["matrix"]][["custom_hovertext"]],
+                               suppress_default_hovertext = F,


False not f

alanocallaghan · 2023-12-23T00:19:37Z

R/plots.R

-    col, ": ", mdf[[2]], "<br>",
-    val, ": ", label_format_fun(mdf[[3]])
-  )
+  if(!suppress_default_hovertext)


Use the same brace style as the rest of the code

alanocallaghan · 2023-12-23T00:20:20Z

R/plots.R

@@ -95,7 +101,13 @@ ggplot_heatmap <- function(xx,
    }
  }
  if (!is.null(custom_hovertext)) {
-    mdf[["text"]] <- paste0(mdf[["text"]], "<br>", custom_hovertext)
+    if(!suppress_default_hovertext)


Invert this if/else

mcsimenc · 2023-12-23T01:28:57Z

@alanocallaghan at least with v1.5, when using custom_hovertext with the plot_method = plotly method the default is not shown.

alanocallaghan · 2023-12-23T01:44:53Z

What I mean is that the behavior should be equivalent

alanocallaghan · 2023-12-23T21:10:24Z

This currently fails with:

heatmaply(mtcars, suppress_default_hovertext=TRUE)
Error in ggplot_heatmap(data_mat, row_text_angle, column_text_angle, scale_fill_gradient_fun,  : 
  object 'suppress_default_hovertext' not found

If I add the arg to ggplot_heatmap, I get:

heatmaply(mtcars, suppress_default_hovertext=TRUE)
Error in `.data$text`:
! Column `text` not found in `.data`.
Run `rlang::last_trace()` to see where the error occurred.

Also hovertext is currently broken generally for plot_method="plotly" so I'd want to resolve that before merging

mcsimenc · 2023-12-24T18:07:08Z

Thanks @alanocallaghan. I added the arg to my fork and it works for me if I install heatmaply from it. Could there be other changes after merging?

talgalili · 2023-12-24T18:34:07Z

Please also add yourself as contributor to the DESCRIPTION file. T

…

On Sun, 24 Dec 2023, 20:07 mcsimenc, ***@***.***> wrote: Thanks @alanocallaghan <https://github.com/alanocallaghan>. I added the arg to my fork and it works for me if I install heatmaply from it. Could there be other changes after merging? — Reply to this email directly, view it on GitHub <#301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHOJBVPA2J5GWVFFYSLPXTYLBVNNAVCNFSM6AAAAABBALV3YWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGU3DSNBXGU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

talgalili · 2024-05-17T17:21:51Z

Hi @mcsimenc
Could you please finish addressing the changes @alanocallaghan requested?
I'd be happy to merge and close this, thanks.

mcsimenc · 2024-05-20T21:12:41Z

Hey guys, I'm so sorry about the lag. I've been so busy with work and home life and haven't returned to this. They are simple changes and I will try to get to it this weekend!

talgalili · 2024-05-20T21:20:11Z

No worries, we all get it :) Thanks 👍🙏

…

On Mon, 20 May 2024, 22:13 mcsimenc, ***@***.***> wrote: Hey guys, I'm so sorry about the lag. I've been so busy with work and home life and haven't returned to this. They are simple changes and I will try to get to it soon! — Reply to this email directly, view it on GitHub <#301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHOJBR2AB52W7DTT4WW7QTZDJRN7AVCNFSM6AAAAABBALV3YWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRGIYTOMZZGY> . You are receiving this because you commented.Message ID: ***@***.***>

talgalili · 2024-07-05T17:42:02Z

Hi @mcsimenc - any update on this? (I'd be happy for you to finish this so I'd include it in the next release)

T

mcsimenc · 2024-07-13T18:15:48Z

Hi Tal and Alan, thanks for your patience. I made the changes and am able to run

heatmaply(mtcars, suppress_default_hovertext=TRUE)

I'll be available over the next two weeks if any other changes need to be made.

talgalili

Please revise a tiny bit and then resubmit. Thanks!

talgalili · 2024-07-13T18:26:31Z

DESCRIPTION

@@ -9,6 +9,7 @@ Authors@R: c(
    person("Jonathan", "Sidi", email = "yonis@metrumrg.com", comment = "https://github.com/yonicd",role = "ctb"),
    person("Jaehyun", "Joo", comment = "https://github.com/jaehyunjoo",role = "ctb"),
    person("Yoav", "Benjamini", email = "ybenja@tau.ac.il",role = "ths"))


Missing a comma

Suggested change

person("Yoav", "Benjamini", email = "ybenja@tau.ac.il",role = "ths"))

person("Yoav", "Benjamini", email = "ybenja@tau.ac.il",role = "ths")),

talgalili · 2024-07-13T18:27:00Z

R/heatmaply.R

@@ -571,6 +571,7 @@ heatmaply.default <- function(x,
                              label_format_fun = function(...) format(..., digits = 4),
                              labRow = NULL, labCol = NULL,
                              custom_hovertext = NULL,
+                              suppress_default_hovertext = F,


Please use FALSE instead of F

Suggested change

suppress_default_hovertext = F,

suppress_default_hovertext = FALSE,

talgalili · 2024-07-13T18:30:16Z

R/plots.R

@@ -95,7 +103,11 @@ ggplot_heatmap <- function(xx,
    }
  }
  if (!is.null(custom_hovertext)) {
-    mdf[["text"]] <- paste0(mdf[["text"]], "<br>", custom_hovertext)
+    if (suppress_default_hovertext) {


All other places you've used ! suppress_default_hovertext, it might be worth be consistent. But your choice on this one.

talgalili · 2024-07-13T18:32:25Z

Hi @mcsimenc
I've reviewed your commit, and made some small comments.
One is critical since it breaks the code (in the DESCRIPTION file)
The other two are stylistic, please take a look.

Thanks!

p.s.: FYI that once you finish I'll squash your commits into a single one, so no worries on making many commits.

mcsimenc · 2024-07-13T18:56:20Z

Got it. I may have misunderstood Alan's comment about inverting the true/false. I switched it to use the negation and made the other changes.

Thank you Tal

mcsimenc · 2024-07-13T19:50:07Z

I removed an extra paren in the DESCRIPTION file that caused R-CMD-check to fail

talgalili · 2024-07-13T19:59:19Z

Great, I'm running the tests again.

talgalili · 2024-07-14T01:42:09Z

@mcsimenc

It's almost there, but there is still an error.
Could you please fix the roxygen2 doc so that the rds is properly set?

Here is one of the errors:

                   colors(256) else colors, na.value = na.value, limits =
                   limits), grid_color = NA, grid_gap = 0, srtRow = NULL,
                   srtCol = NULL, xlab = "", ylab = "", main = "", titleX
                   = TRUE, titleY = TRUE, hide_colorbar = FALSE,
                   key.title = NULL, return_ppxpy = FALSE, draw_cellnote
                   = FALSE, cellnote_color = "auto",
                   cellnote_textposition = "middle right", cellnote_size
                   = 12, row_side_colors = x[["row_side_colors"]],
                   row_side_palette = NULL, col_side_colors =
                   x[["col_side_colors"]], col_side_palette = NULL,
                   plot_method = c("ggplot", "plotly"), ColSideColors =
                   NULL, RowSideColors = NULL, heatmap_layers = NULL,
                   side_color_layers = NULL, dendrogram_layers = NULL,
                   branches_lwd = 0.6, label_names = c("row", "column",
                   "value"), fontsize_row = 10, fontsize_col = 10,
                   subplot_widths = NULL, subplot_heights = NULL,
                   colorbar_xanchor = if (row_dend_left) "right" else
                   "left", colorbar_yanchor = "bottom", colorbar_xpos =
                   if (row_dend_left) -0.1 else 1.1, colorbar_ypos = 0,
                   colorbar_len = 0.3, colorbar_thickness = 30,
                   showticklabels = c(TRUE, TRUE), dynamicTicks = FALSE,
                   node_type = c("scatter", "heatmap"), grid_size = 0.1,
                   point_size_mat = x[["matrix"]][["point_size_mat"]],
                   point_size_name = "Point size", label_format_fun =
                   function(...) format(..., digits = 4),
                   custom_hovertext =
                   x[["matrix"]][["custom_hovertext"]],
                   suppress_default_hovertext = FALSE, dend_hoverinfo =
                   TRUE, side_color_colorbar_len = 0.3, plotly_source =
                   "A", height = NULL, width = NULL)
    Docs: function(x, colors = viridis(n = 256, alpha = 1, begin = 0, end
                   = 1, option = "viridis"), limits = NULL, na.value =
                   "grey50", row_text_angle = 0, column_text_angle = 45,
                   subplot_margin = 0, row_dend_left = FALSE, margins =
                   c(NA, NA, NA, NA), ..., scale_fill_gradient_fun =
                   scale_fill_gradientn(colors = if (is.function(colors))
                   colors(256) else colors, na.value = na.value, limits =
                   limits), grid_color = NA, grid_gap = 0, srtRow = NULL,
                   srtCol = NULL, xlab = "", ylab = "", main = "", titleX
                   = TRUE, titleY = TRUE, hide_colorbar = FALSE,
                   key.title = NULL, return_ppxpy = FALSE, draw_cellnote
                   = FALSE, cellnote_color = "auto",
                   cellnote_textposition = "middle right", cellnote_size
                   = 12, row_side_colors = x[["row_side_colors"]],
                   row_side_palette = NULL, col_side_colors =
                   x[["col_side_colors"]], col_side_palette = NULL,
                   plot_method = c("ggplot", "plotly"), ColSideColors =
                   NULL, RowSideColors = NULL, heatmap_layers = NULL,
                   side_color_layers = NULL, dendrogram_layers = NULL,
                   branches_lwd = 0.6, label_names = c("row", "column",
                   "value"), fontsize_row = 10, fontsize_col = 10,
                   subplot_widths = NULL, subplot_heights = NULL,
                   colorbar_xanchor = if (row_dend_left) "right" else
                   "left", colorbar_yanchor = "bottom", colorbar_xpos =
                   if (row_dend_left) -0.1 else 1.1, colorbar_ypos = 0,
                   colorbar_len = 0.3, colorbar_thickness = 30,
                   showticklabels = c(TRUE, TRUE), dynamicTicks = FALSE,
                   node_type = c("scatter", "heatmap"), grid_size = 0.1,
                   point_size_mat = x[["matrix"]][["point_size_mat"]],
                   point_size_name = "Point size", label_format_fun =
                   function(...) format(..., digits = 4),
                   custom_hovertext =
                   x[["matrix"]][["custom_hovertext"]], dend_hoverinfo =
                   TRUE, side_color_colorbar_len = 0.3, plotly_source =
                   "A", height = NULL, width = NULL)
    Argument names in code not in docs:
      suppress_default_hovertext
    Mismatches in argument names (first 3):
      Position: 58 Code: suppress_default_hovertext Docs: dend_hoverinfo
      Position: 59 Code: dend_hoverinfo Docs: side_color_colorbar_len
      Position: 60 Code: side_color_colorbar_len Docs: plotly_source

❯ checking Rd \usage sections ... WARNING
  Documented arguments not in \usage in Rd file 'heatmaply.Rd':
    ‘suppress_default_hovertext’

mcsimenc · 2024-07-14T05:26:46Z

Ok, @param added.

talgalili · 2024-07-14T18:34:37Z

Hi @mcsimenc

I see there is still an issue with the rd file. Could you please resolve it?
Here is the message:


❯ checking for code/documentation mismatches ... WARNING
  Codoc mismatches from Rd file 'heatmaply.Rd':
  heatmaply.default
    Code: function(x, colors = viridis(n = 256, alpha = 1, begin = 0, end
                   = 1, option = "viridis"), limits = NULL, na.value =
                   "grey50", row_text_angle = 0, column_text_angle = 45,
                   subplot_margin = 0, cellnote = NULL, draw_cellnote =
                   !is.null(cellnote), cellnote_color = "auto",
                   cellnote_textposition = "middle right", cellnote_size
                   = 12, Rowv = NULL, Colv = NULL, distfun = stats::dist,
                   hclustfun = stats::hclust, dist_method = NULL,
                   hclust_method = NULL, distfun_row = distfun,
                   hclustfun_row = hclustfun, distfun_col = distfun,
                   hclustfun_col = hclustfun, dendrogram = c("both",
                   "row", "column", "none"), show_dendrogram = c(TRUE,
                   TRUE), reorderfun = function(d, w) reorder(d, w),
                   k_row = 1, k_col = 1, symm = FALSE, revC = symm ||
                   (is.dendrogram(Colv) & is.dendrogram(Rowv) &
                   identical(Rowv, rev(Colv))), scale = c("none", "row",
                   "column"), na.rm = TRUE, row_dend_left = FALSE,
                   margins = c(NA, NA, NA, NA), ...,
                   scale_fill_gradient_fun = NULL, grid_color = NA,
                   grid_gap = 0, srtRow = NULL, srtCol = NULL, xlab = "",
                   ylab = "", main = "", titleX = TRUE, titleY = TRUE,
                   hide_colorbar = FALSE, key.title = NULL, return_ppxpy
                   = FALSE, row_side_colors = NULL, row_side_palette =
                   NULL, col_side_colors = NULL, col_side_palette = NULL,
                   ColSideColors = NULL, RowSideColors = NULL, seriate =
                   c("OLO", "mean", "none", "GW"), heatmap_layers = NULL,
                   side_color_layers = NULL, dendrogram_layers = NULL,
                   branches_lwd = 0.6, file = NULL, width = NULL, height
                   x[["matrix"]][["custom_hovertext"]],
                   suppress_default_hovertext = FALSE, dend_hoverinfo =
                   TRUE, side_color_colorbar_len = 0.3, plotly_source =
                   "A", height = NULL, width = NULL)
    Docs: function(x, colors = viridis(n = 256, alpha = 1, begin = 0, end
                   = 1, option = "viridis"), limits = NULL, na.value =
                   "grey50", row_text_angle = 0, column_text_angle = 45,
                   subplot_margin = 0, row_dend_left = FALSE, margins =
                   c(NA, NA, NA, NA), ..., scale_fill_gradient_fun =
                   scale_fill_gradientn(colors = if (is.function(colors))
                   colors(256) else colors, na.value = na.value, limits =
                   limits), grid_color = NA, grid_gap = 0, srtRow = NULL,
                   srtCol = NULL, xlab = "", ylab = "", main = "", titleX
                   = TRUE, titleY = TRUE, hide_colorbar = FALSE,
                   key.title = NULL, return_ppxpy = FALSE, draw_cellnote
                   = FALSE, cellnote_color = "auto",
                   cellnote_textposition = "middle right", cellnote_size
                   = 12, row_side_colors = x[["row_side_colors"]],
                   row_side_palette = NULL, col_side_colors =
                   x[["col_side_colors"]], col_side_palette = NULL,
                   plot_method = c("ggplot", "plotly"), ColSideColors =
                   NULL, RowSideColors = NULL, heatmap_layers = NULL,
                   side_color_layers = NULL, dendrogram_layers = NULL,
                   branches_lwd = 0.6, label_names = c("row", "column",
                   "value"), fontsize_row = 10, fontsize_col = 10,
                   subplot_widths = NULL, subplot_heights = NULL,
                   colorbar_xanchor = if (row_dend_left) "right" else
                   "left", colorbar_yanchor = "bottom", colorbar_xpos =
                   if (row_dend_left) -0.1 else 1.1, colorbar_ypos = 0,
                   colorbar_len = 0.3, colorbar_thickness = 30,
                   showticklabels = c(TRUE, TRUE), dynamicTicks = FALSE,
                   node_type = c("scatter", "heatmap"), grid_size = 0.1,
                   point_size_mat = x[["matrix"]][["point_size_mat"]],
                   point_size_name = "Point size", label_format_fun =
                   function(...) format(..., digits = 4),
                   custom_hovertext =
                   x[["matrix"]][["custom_hovertext"]], dend_hoverinfo =
                   TRUE, side_color_colorbar_len = 0.3, plotly_source =
                   "A", height = NULL, width = NULL)
    Argument names in code not in docs:
      suppress_default_hovertext
    Mismatches in argument names (first 3):
      Position: 58 Code: suppress_default_hovertext Docs: dend_hoverinfo
      Position: 59 Code: dend_hoverinfo Docs: side_color_colorbar_len
      Position: 60 Code: side_color_colorbar_len Docs: plotly_source

❯ checking Rd \usage sections ... WARNING
  Documented arguments not in \usage in Rd file 'heatmaply.Rd':
    ‘suppress_default_hovertext’
  
  Functions with \usage entries need to have the appropriate \alias
  entries, and all their arguments documented.
  The \usage entries must correspond to syntactically valid R code.
  See chapter ‘Writing R documentation files’ in the ‘Writing R
  Extensions’ manual.

talgalili · 2024-07-14T18:56:16Z

Thanks.
I'm running checks again.

… and modified param descriptions in R files to match.

mcsimenc · 2024-07-15T01:11:28Z

Ok, Tal, try again!

codecov-commenter · 2024-07-15T03:38:20Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (81bae36) to head (d7cb596).
Report is 3 commits behind head on master.

Files	Patch %	Lines
R/plots.R	84.61%	2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.02%     
==========================================
  Files           9        9              
  Lines        1346     1356      +10     
==========================================
+ Hits         1234     1243       +9     
- Misses        112      113       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

talgalili · 2024-07-15T04:02:36Z

Almost there.
One last warning

❯ checking for code/documentation mismatches ... WARNING
  Codoc mismatches from Rd file 'heatmapr.Rd':
  heatmapr
    Code: function(x, Rowv = NULL, Colv = NULL, distfun = dist, hclustfun
                   = hclust, dist_method = NULL, hclust_method = NULL,
                   distfun_row = distfun, hclustfun_row = hclustfun,
                   distfun_col = distfun, hclustfun_col = hclustfun,
                   dendrogram = c("both", "row", "column", "none"),
                   show_dendrogram = c(TRUE, TRUE), reorderfun =
                   function(d, w) reorder(d, w), k_row = 1, k_col = 1,
                   symm = FALSE, revC = symm || (is.dendrogram(Colv) &
                   is.dendrogram(Rowv) & identical(Rowv, rev(Colv))),
                   scale = c("none", "row", "column"), na.rm = TRUE,
                   labRow = rownames(x), labCol = colnames(x), cexRow =
                   NULL, cexCol = NULL, digits = 3L, cellnote = NULL,
                   theme = NULL, colors = "RdYlBu", width = NULL, height
                   = NULL, xaxis_height = 80, yaxis_width = 120,
                   xaxis_font_size = NULL, yaxis_font_size = NULL,
                   brush_color = "#0000FF", show_grid = TRUE,
                   anim_duration = 500, row_side_colors = NULL,
                   col_side_colors = NULL, seriate = c("OLO", "mean",
                   "none", "GW"), point_size_mat = NULL, custom_hovertext
                   = NULL, ...)
    Docs: function(x, Rowv = NULL, Colv = NULL, distfun = dist, hclustfun
                   = hclust, dist_method = NULL, hclust_method = NULL,
                   distfun_row = distfun, hclustfun_row = hclustfun,
                   distfun_col = distfun, hclustfun_col = hclustfun,
                   dendrogram = c("both", "row", "column", "none"),
                   show_dendrogram = c(TRUE, TRUE), reorderfun =
                   function(d, w) reorder(d, w), k_row = 1, k_col = 1,
                   symm = FALSE, revC = symm || (is.dendrogram(Colv) &
                   is.dendrogram(Rowv) & identical(Rowv, rev(Colv))),
                   scale = c("none", "row", "column"), na.rm = TRUE,
                   labRow = rownames(x), labCol = colnames(x), cexRow =
                   NULL, cexCol = NULL, digits = 3L, cellnote = NULL,
                   theme = NULL, colors = "RdYlBu", width = NULL, height
                   = NULL, xaxis_height = 80, yaxis_width = 120,
                   xaxis_font_size = NULL, yaxis_font_size = NULL,
                   brush_color = "#0000FF", show_grid = TRUE,
                   anim_duration = 500, row_side_colors = NULL,
                   col_side_colors = NULL, seriate = c("OLO", "mean",
                   "none", "GW"), point_size_mat = NULL, custom_hovertext
                   = NULL, suppress_default_hovertext = FALSE, ...)
    Argument names in docs not in code:
      suppress_default_hovertext
    Mismatches in argument names:
      Position: 43 Code: ... Docs: suppress_default_hovertext

talgalili · 2024-07-15T04:04:20Z

Make sure the relative location of the roxygen2 param is the same as in the code.
And run roxygen2 to include the change.

talgalili · 2024-07-15T05:09:13Z

@mcsimenc
I still see the error.
Are you still up to trying to resolve it?

2m 0s
                 theme = NULL, colors = "RdYlBu", width = NULL, height
                 = NULL, xaxis_height = 80, yaxis_width = 120,
                 xaxis_font_size = NULL, yaxis_font_size = NULL,
                 brush_color = "#0000FF", show_grid = TRUE,
                 anim_duration = 500, row_side_colors = NULL,
                 col_side_colors = NULL, seriate = c("OLO", "mean",
                 "none", "GW"), point_size_mat = NULL, custom_hovertext
                 = NULL, suppress_default_hovertext = FALSE, ...)
  Argument names in docs not in code:
    suppress_default_hovertext
  Mismatches in argument names:
    Position: 43 Code: ... Docs: suppress_default_hovertext
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking installed files from ‘inst/doc’ ... OK
* checking files in ‘vignettes’ ... OK
* checking examples ... OK
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ...
  Running ‘testthat.R’ [80s/57s]
 [80s/57s] OK
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes ... OK
* checking re-building of vignette outputs ... [16s/13s] OK
* checking for non-standard things in the check directory ... OK
* checking for detritus in the temp directory ... OK
* DONE
Status: 1 WARNING, 3 NOTEs
See
  ‘/home/runner/work/heatmaply/heatmaply/check/heatmaply.Rcheck/00check.log’
for details.
── R CMD check results ──────────────────────────────────── heatmaply 1.5.0 ────
Duration: 1m 40.8s

❯ checking for code/documentation mismatches ... WARNING
  Codoc mismatches from Rd file 'heatmapr.Rd':
  heatmapr
    Code: function(x, Rowv = NULL, Colv = NULL, distfun = dist, hclustfun
                   = hclust, dist_method = NULL, hclust_method = NULL,
                   distfun_row = distfun, hclustfun_row = hclustfun,
                   distfun_col = distfun, hclustfun_col = hclustfun,
                   dendrogram = c("both", "row", "column", "none"),
                   show_dendrogram = c(TRUE, TRUE), reorderfun =
                   function(d, w) reorder(d, w), k_row = 1, k_col = 1,
                   symm = FALSE, revC = symm || (is.dendrogram(Colv) &
                   is.dendrogram(Rowv) & identical(Rowv, rev(Colv))),
                   scale = c("none", "row", "column"), na.rm = TRUE,
                   labRow = rownames(x), labCol = colnames(x), cexRow =
                   NULL, cexCol = NULL, digits = 3L, cellnote = NULL,
                   theme = NULL, colors = "RdYlBu", width = NULL, height
                   = NULL, xaxis_height = 80, yaxis_width = 120,
                   xaxis_font_size = NULL, yaxis_font_size = NULL,
                   brush_color = "#0000FF", show_grid = TRUE,
                   anim_duration = 500, row_side_colors = NULL,
                   col_side_colors = NULL, seriate = c("OLO", "mean",
                   "none", "GW"), point_size_mat = NULL, custom_hovertext
                   = NULL, ...)
    Docs: function(x, Rowv = NULL, Colv = NULL, distfun = dist, hclustfun
                   = hclust, dist_method = NULL, hclust_method = NULL,
                   distfun_row = distfun, hclustfun_row = hclustfun,
                   distfun_col = distfun, hclustfun_col = hclustfun,
                   dendrogram = c("both", "row", "column", "none"),
                   show_dendrogram = c(TRUE, TRUE), reorderfun =
                   function(d, w) reorder(d, w), k_row = 1, k_col = 1,
                   symm = FALSE, revC = symm || (is.dendrogram(Colv) &
                   is.dendrogram(Rowv) & identical(Rowv, rev(Colv))),
                   scale = c("none", "row", "column"), na.rm = TRUE,
                   labRow = rownames(x), labCol = colnames(x), cexRow =
                   NULL, cexCol = NULL, digits = 3L, cellnote = NULL,
                   theme = NULL, colors = "RdYlBu", width = NULL, height
                   = NULL, xaxis_height = 80, yaxis_width = 120,
                   xaxis_font_size = NULL, yaxis_font_size = NULL,
                   brush_color = "#0000FF", show_grid = TRUE,
                   anim_duration = 500, row_side_colors = NULL,
                   col_side_colors = NULL, seriate = c("OLO", "mean",
                   "none", "GW"), point_size_mat = NULL, custom_hovertext
                   = NULL, suppress_default_hovertext = FALSE, ...)
    Argument names in docs not in code:
      suppress_default_hovertext
    Mismatches in argument names:
      Position: 43 Code: ... Docs: suppress_default_hovertext

mcsimenc · 2024-07-15T23:14:10Z

Hi Tal, yes trying to resolve it. The params are the same in the docs and the function def, and I ran roxygenise(). Should that do it?

talgalili · 2024-07-16T08:18:19Z

Hi, Did you push your updates? The latest check I ran still doesn't seem to have resolved the issue.

…

On Tue, 16 Jul 2024, 2:14 mcsimenc, ***@***.***> wrote: Hi Tal, yes trying to resolve it. The params are the same in the docs and the function def, and I ran roxygenise(). Should that do it? — Reply to this email directly, view it on GitHub <#301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHOJBQGCPGVQMKZDPW6CGTZMRJVRAVCNFSM6AAAAABBALV3YWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGYYDCNRXGE> . You are receiving this because you commented.Message ID: ***@***.***>

mcsimenc · 2024-07-16T16:07:36Z

No, I didn't, until just now. Thanks Tal

…

On Tue, Jul 16, 2024 at 1:18 AM Tal Galili ***@***.***> wrote: Hi, Did you push your updates? The latest check I ran still doesn't seem to have resolved the issue. On Tue, 16 Jul 2024, 2:14 mcsimenc, ***@***.***> wrote: > Hi Tal, yes trying to resolve it. The params are the same in the docs and > the function def, and I ran roxygenise(). Should that do it? > > — > Reply to this email directly, view it on GitHub > <#301 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAHOJBQGCPGVQMKZDPW6CGTZMRJVRAVCNFSM6AAAAABBALV3YWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGYYDCNRXGE> > . > You are receiving this because you commented.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYL2ZT6LX2GA2DYWB5KJBLZMTJOBAVCNFSM6AAAAABBALV3YWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGI4TSOJSGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

talgalili · 2024-07-16T17:39:52Z

Congrats 👏🎉
It seems to pass!
I'm squashing and merging to main :)

mcsimenc · 2024-07-16T21:55:25Z

Awesome!

Add option suppress_default_hovertext

1e9b9c6

alanocallaghan requested changes Dec 23, 2023

View reviewed changes

Add suppress hovertext arg to ggplot_heatmap

fa13404

mcsimenc@gmail.com and others added 5 commits July 13, 2024 10:19

Style changes and invert if/else

efb3cd7

revert if/else switch

6ce178e

Try fix for empty text slot with no custom and no default hovertext

09ed7bb

conform if style

14fb1de

Add Matt Simenc to DESCRIPTION as contributor

d5457bb

talgalili requested changes Jul 13, 2024

View reviewed changes

Fix DESCRIPTION, conform style, and improve consistency in logic

fdca505

Removed extra paren in DESCRIPTION file

65baa46

Added roxygen documentation for suppress_default_hovertext

b91f710

Add @param for suppress_default_hovertext to heatmapr

07a1baa

Added item to roxygen Rd documentation for suppress_default_hovertext…

d7cb596

… and modified param descriptions in R files to match.

Remove @param for suppress_default_hovertext in heatmapr.R

ab4c678

Ran roxygenise

40f0e84

talgalili merged commit 424dae0 into talgalili:master Jul 16, 2024
11 of 13 checks passed

	person("Yoav", "Benjamini", email = "ybenja@tau.ac.il",role = "ths"))
	person("Yoav", "Benjamini", email = "ybenja@tau.ac.il",role = "ths")),

	suppress_default_hovertext = F,
	suppress_default_hovertext = FALSE,

Add option suppress_default_hovertext for plot_method = "ggplot" #301

Add option suppress_default_hovertext for plot_method = "ggplot" #301

Conversation

mcsimenc commented Dec 22, 2023

alanocallaghan left a comment

Choose a reason for hiding this comment

alanocallaghan Dec 23, 2023

Choose a reason for hiding this comment

alanocallaghan Dec 23, 2023

Choose a reason for hiding this comment

alanocallaghan Dec 23, 2023

Choose a reason for hiding this comment

mcsimenc commented Dec 23, 2023

alanocallaghan commented Dec 23, 2023

alanocallaghan commented Dec 23, 2023 • edited Loading

mcsimenc commented Dec 24, 2023

talgalili commented Dec 24, 2023 via email

talgalili commented May 17, 2024

mcsimenc commented May 20, 2024 • edited Loading

talgalili commented May 20, 2024 via email

talgalili commented Jul 5, 2024

mcsimenc commented Jul 13, 2024

talgalili left a comment

Choose a reason for hiding this comment

talgalili Jul 13, 2024

Choose a reason for hiding this comment

talgalili Jul 13, 2024

Choose a reason for hiding this comment

talgalili Jul 13, 2024

Choose a reason for hiding this comment

talgalili commented Jul 13, 2024

mcsimenc commented Jul 13, 2024

mcsimenc commented Jul 13, 2024

talgalili commented Jul 13, 2024

talgalili commented Jul 14, 2024

mcsimenc commented Jul 14, 2024

talgalili commented Jul 14, 2024

talgalili commented Jul 14, 2024

mcsimenc commented Jul 15, 2024

codecov-commenter commented Jul 15, 2024

Codecov Report

talgalili commented Jul 15, 2024

talgalili commented Jul 15, 2024

talgalili commented Jul 15, 2024 • edited Loading

mcsimenc commented Jul 15, 2024

talgalili commented Jul 16, 2024 via email

mcsimenc commented Jul 16, 2024 via email

talgalili commented Jul 16, 2024

mcsimenc commented Jul 16, 2024

alanocallaghan commented Dec 23, 2023 •

edited

Loading

mcsimenc commented May 20, 2024 •

edited

Loading

talgalili commented Jul 15, 2024 •

edited

Loading