Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store embeddings in Instance or Frame Objects #35

Closed
aaprasad opened this issue May 1, 2024 · 1 comment
Closed

Store embeddings in Instance or Frame Objects #35

aaprasad opened this issue May 1, 2024 · 1 comment
Assignees

Comments

@aaprasad
Copy link
Contributor

aaprasad commented May 1, 2024

To prevent confusion of the return type in biogtr.models.Transformer, the only output of the transformer should be the association matrix. If we want to store the position embeddings for debugging we should instead save it at the frame or instance level (depending on what level of granularity we want). Instance level is probably better considering we also store instance features/crops/etc at the instance level and we want to move from using Frame objects as inputs to the model to Instance Objects. Thus, we need to add a embedding attribute to the Instance object similar to how we store the trajectory scores.

@aaprasad aaprasad self-assigned this May 21, 2024
@aaprasad
Copy link
Contributor Author

aaprasad commented Jun 3, 2024

Handled in #47

@aaprasad aaprasad closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant