Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.9 GitHub tests #111

Closed
wants to merge 2 commits into from
Closed

Python 3.9 GitHub tests #111

wants to merge 2 commits into from

Conversation

keyaloding
Copy link

Description

Pull request #104 cannot be merged because Windows tests are not passing because the GitHub workflow takes >15 minutes, even though MacOS and Linux tests are passing. I have changed the GitHub workflow so that the maximum test time is 40 minutes (changed from 15 minutes) and this branch only tests Python 3.9

Types of changes

  • Bugfix
  • [] New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • [] Documentation Update
  • Other (explain)

Does this address any currently open issues?

Thank you for contributing to SLEAP!

❤️

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 27, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.87324% with 45 lines in your changes missing coverage. Please review.

Project coverage is 94.12%. Comparing base (e002927) to head (7953e49).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sleap_io/io/nwb.py 79.41% 42 Missing ⚠️
sleap_io/io/main.py 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   96.01%   94.12%   -1.90%     
==========================================
  Files          17       17              
  Lines        2035     2229     +194     
==========================================
+ Hits         1954     2098     +144     
- Misses         81      131      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keyaloding keyaloding closed this Aug 30, 2024
@keyaloding keyaloding deleted the kloding/nwb_python3_9 branch August 30, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@keyaloding