Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freerasp-react-native could not determine the react-native version used #38

Closed
mohcinenazrhan opened this issue Nov 30, 2023 · 1 comment · Fixed by #40
Closed

freerasp-react-native could not determine the react-native version used #38

mohcinenazrhan opened this issue Nov 30, 2023 · 1 comment · Fixed by #40
Assignees
Labels
bug Something isn't working to be fixed This issue will be fixed in the future

Comments

@mohcinenazrhan
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch freerasp-react-native@3.3.1 for the project I'm working on.

After installing this package, I got this problem:

Could not determine the dependencies of task ':freerasp-react-native:compileDebugAidl'.

Could not resolve all task dependencies for configuration ':freerasp-react-native:debugCompileClasspath'.
Could not find com.facebook.react:react-native:.
Required by:
project :freerasp-react-native

Here is the diff that solved my problem:

diff --git a/node_modules/freerasp-react-native/android/build.gradle b/node_modules/freerasp-react-native/android/build.gradle
index dc11f30..7bb74ed 100644
--- a/node_modules/freerasp-react-native/android/build.gradle
+++ b/node_modules/freerasp-react-native/android/build.gradle
@@ -83,7 +83,7 @@ dependencies {
   // For < 0.71, this will be from the local maven repo
   // For > 0.71, this will be replaced by `com.facebook.react:react-android:$version` by react gradle plugin
   //noinspection GradleDynamicVersion
-  implementation "com.facebook.react:react-native"
+  implementation "com.facebook.react:react-native:0.70.3"
   implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
   implementation "com.aheaditec.talsec.security:TalsecSecurity-Community-ReactNative:8.0.4"
 }
@tompsota
Copy link
Member

tompsota commented Dec 4, 2023

Hi @mohcinenazrhan,

Thanks for opening the issue! We were aware that this occurs with older versions of react-native and always proposed the same fix as you did (to hardcode the version of react-native).

It seems like a general solution would be to use implementation "com.facebook.react:react-native:+, but we will have to do some testing to see if we don't break the versions that are currently working.

This should be ready in the next release.

Cheers,
Tomas, Talsec dev

@tompsota tompsota self-assigned this Dec 4, 2023
@tompsota tompsota added the bug Something isn't working label Dec 4, 2023
@msikyna msikyna added the to be fixed This issue will be fixed in the future label Jan 2, 2024
@tompsota tompsota mentioned this issue Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to be fixed This issue will be fixed in the future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants