Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode settings needs extension reload to be applied #375

Closed
echoix opened this issue Jan 28, 2023 · 3 comments · Fixed by #452
Closed

VSCode settings needs extension reload to be applied #375

echoix opened this issue Jan 28, 2023 · 3 comments · Fixed by #452

Comments

@echoix
Copy link

echoix commented Jan 28, 2023

I wasn't able to configure the settings for the VSCode extensions.

I was trying all the options one by one, and never I had a different output. I was in a GitHub codespaces, so I switched back to a local-only setup, and same thing, I wasn't able to have formatting settings applied. I made sure to set a different string to the indent string between tests.

I wanted to at least have some indented entries for a hugo config.toml. I tried out by installing other older versions to see if any version of the extension has ever worked. And yes! But also the new one. The key was by installing an older version, it needed a reload, and the reload was what it took to have the settings applied.

So I suppose that the default state when installing the extension, that is, formatting the file real flat, (nothing is indented, all spaces/tabs removed at the beginning of lines), was only since is there is no key for "evenBetterToml.formatter.indentString" in the settings.json, the empty textbox in the UI means "", (an empty string).

image
image
image

This is when the setting is reset:
image

@davidtorosyan
Copy link

+1, just spent a bunch of time trying to figure out why my changes to taplo.toml weren't working.

Could we maybe add a note to the extension README, in the configuration file section? I don't mind reloading, but it would be good to know it's needed.

@ZhiliangWu
Copy link
Contributor

Yes, it would be great if it's at least mentioned in README.

@ia0
Copy link
Collaborator

ia0 commented Aug 8, 2023

Thanks for the diagnosis! However this project is only passively maintained. Feel free to open a PR with the appropriate suggested change in the README regarding the mentioned documentation issue. I'll review and approve or comment it. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants