Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for autocompleting package names, package versions, and features in Cargo.toml #689

Open
kurtbuilds opened this issue Oct 19, 2024 · 2 comments
Labels

Comments

@kurtbuilds
Copy link

There are a few efforts to create separate LSPs for autocompleting package names, package versions, and features in Cargo.toml (https://github.com/frederik-uni/cargotom; https://github.com/washanhanzi/cargo-appraiser/).

Is it in scope to add support for this feature to this project?

@panekj
Copy link
Collaborator

panekj commented Oct 20, 2024

Is it in scope to add support for this feature to this project?

Not really. Taplo is working solely off JSON schemas as it's meant for TOML validation. Any support for specific file format such as e.g. Cargo should be handled separately.

@kurtbuilds
Copy link
Author

kurtbuilds commented Oct 20, 2024

Ok.

Right now taplo is the default LSP for Zed (my motivation), but it impedes first time UX to not fully support Cargo.toml, and it's redundant to maintain two DOM implementations, run two LSPs for the same file in parallel, etc.

I submitted a draft PR that starts to implement this, as I want this for my editor use, and I want to support zed and the greater community. If it's out of scope, I'll discuss with Zed team what they prefer if taplo doesn't intend to fully support cargo.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants