File extension determination is wrong

[exislow]

I did some research and found out that this behavior is wrong:

python-tidal/tidalapi/media.py

Lines 619 to 637 in 1720a0b

	def get_file_extension(stream_url: str, stream_codec: Optional[str] = None) -> str:
	if AudioExtensions.FLAC in stream_url:
	result: str = AudioExtensions.FLAC
	elif AudioExtensions.MP4 in stream_url:
	if stream_codec:
	if Codec.AC4 is stream_codec:
	result: str = AudioExtensions.MP4
	elif Codec.FLAC is stream_codec:
	result: str = AudioExtensions.FLAC
	else:
	result: str = AudioExtensions.M4A
	else:
	result: str = AudioExtensions.MP4
	elif VideoExtensions.TS in stream_url:
	result: str = VideoExtensions.TS
	else:
	result: str = AudioExtensions.M4A
	return result

We need to separate the used codec and the file extension. Since, if a file is returned as MP4 it still can have a FLAC encoded audio channel, but the container is indeed an MP4 container.

What happens here is, if stream has ".mp4" in it's file name, the lines above try to check the used codec and wrongly adapt the file extension. To overcome this problem problem I propose solely rely on the extension within the URL. I have a problem which is related to this exislow/tidal-dl-ng#232

A lot of debugging led me to this conclusion. I will propose a solution with a PR.

[exislow]

Here you go: #305