[BUG FIX] Fix the visit of sub queries for HasParentQuery and HasChildQuery (opensearch-project#18621)

* ADD Parent-Join visit method.

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>

* ADD Parent-Join visit method.

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>

* ADD Parent-Join visit method.

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>

* ADD Parent-Join visit method.

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>

---------

Signed-off-by: luyuncheng <luyuncheng@bytedance.com>

Author: luyuncheng

CHANGELOG.md

@@ -34,6 +34,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Add task cancellation checks in aggregators ([#18426](https://github.com/opensearch-project/OpenSearch/pull/18426))
 - Fix concurrent timings in profiler ([#18540](https://github.com/opensearch-project/OpenSearch/pull/18540))
 - Cannot communicate with HTTP/2 when reactor-netty is enabled ([#18599](https://github.com/opensearch-project/OpenSearch/pull/18599))
+- Fix the visit of sub queries for HasParentQuery and HasChildQuery ([#18621](https://github.com/opensearch-project/OpenSearch/pull/18621))
+
 
 ### Security
 

modules/parent-join/src/main/java/org/opensearch/join/query/HasChildQueryBuilder.java

@@ -34,6 +34,7 @@
 import org.apache.lucene.index.DirectoryReader;
 import org.apache.lucene.index.IndexReader;
 import org.apache.lucene.index.OrdinalMap;
+import org.apache.lucene.search.BooleanClause;
 import org.apache.lucene.search.IndexSearcher;
 import org.apache.lucene.search.MatchNoDocsQuery;
 import org.apache.lucene.search.Query;
@@ -58,6 +59,7 @@
 import org.opensearch.index.query.InnerHitContextBuilder;
 import org.opensearch.index.query.NestedQueryBuilder;
 import org.opensearch.index.query.QueryBuilder;
+import org.opensearch.index.query.QueryBuilderVisitor;
 import org.opensearch.index.query.QueryRewriteContext;
 import org.opensearch.index.query.QueryShardContext;
 import org.opensearch.index.query.QueryShardException;
@@ -551,4 +553,10 @@ protected void extractInnerHitBuilders(Map<String, InnerHitContextBuilder> inner
             innerHits.put(name, innerHitContextBuilder);
         }
     }
+
+    @Override
+    public void visit(QueryBuilderVisitor visitor) {
+        visitor.accept(this);
+        query.visit(visitor.getChildVisitor(BooleanClause.Occur.MUST));
+    }
 }

modules/parent-join/src/main/java/org/opensearch/join/query/HasParentQueryBuilder.java

@@ -31,6 +31,7 @@
 
 package org.opensearch.join.query;
 
+import org.apache.lucene.search.BooleanClause;
 import org.apache.lucene.search.MatchNoDocsQuery;
 import org.apache.lucene.search.Query;
 import org.apache.lucene.search.join.ScoreMode;
@@ -48,6 +49,7 @@
 import org.opensearch.index.query.InnerHitBuilder;
 import org.opensearch.index.query.InnerHitContextBuilder;
 import org.opensearch.index.query.QueryBuilder;
+import org.opensearch.index.query.QueryBuilderVisitor;
 import org.opensearch.index.query.QueryRewriteContext;
 import org.opensearch.index.query.QueryShardContext;
 import org.opensearch.index.query.QueryShardException;
@@ -331,4 +333,9 @@ protected void extractInnerHitBuilders(Map<String, InnerHitContextBuilder> inner
         }
     }
 
+    @Override
+    public void visit(QueryBuilderVisitor visitor) {
+        visitor.accept(this);
+        query.visit(visitor.getChildVisitor(BooleanClause.Occur.MUST));
+    }
 }

modules/parent-join/src/test/java/org/opensearch/join/query/HasChildQueryBuilderTests.java

@@ -69,10 +69,12 @@
 import org.opensearch.test.VersionUtils;
 
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 
 import static org.opensearch.common.xcontent.XContentFactory.jsonBuilder;
@@ -392,4 +394,13 @@ public void testDisallowExpensiveQueries() {
         OpenSearchException e = expectThrows(OpenSearchException.class, () -> queryBuilder.toQuery(queryShardContext));
         assertEquals("[joining] queries cannot be executed when 'search.allow_expensive_queries' is set to false.", e.getMessage());
     }
+
+    public void testVisit() {
+        HasChildQueryBuilder builder = doCreateTestQueryBuilder();
+
+        List<QueryBuilder> visitedQueries = new ArrayList<>();
+        builder.visit(createTestVisitor(visitedQueries));
+
+        assertEquals(2, visitedQueries.size());
+    }
 }

modules/parent-join/src/test/java/org/opensearch/join/query/HasParentQueryBuilderTests.java

@@ -58,10 +58,12 @@
 import org.opensearch.test.VersionUtils;
 
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 
 import static org.opensearch.common.xcontent.XContentFactory.jsonBuilder;
@@ -290,4 +292,13 @@ public void testDisallowExpensiveQueries() {
         OpenSearchException e = expectThrows(OpenSearchException.class, () -> queryBuilder.toQuery(queryShardContext));
         assertEquals("[joining] queries cannot be executed when 'search.allow_expensive_queries' is set to false.", e.getMessage());
     }
+
+    public void testVisit() {
+        HasParentQueryBuilder builder = doCreateTestQueryBuilder();
+
+        List<QueryBuilder> visitedQueries = new ArrayList<>();
+        builder.visit(createTestVisitor(visitedQueries));
+
+        assertEquals(2, visitedQueries.size());
+    }
 }