Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WebView response output renderer #90

Closed
RandomFractals opened this issue Apr 26, 2021 · 8 comments
Closed

add WebView response output renderer #90

RandomFractals opened this issue Apr 26, 2021 · 8 comments

Comments

@RandomFractals
Copy link
Contributor

for rendering actual web pages, in addition to XMLView to display html response in xml tree (#86)

@RandomFractals
Copy link
Contributor Author

we can probably just use iframe for this and set it to GET url for the page to get started.

@tanhakabir
Copy link
Owner

By webview, do you mean by a rendered view of the html received? if this is the case there is actually already an output for rendered html

@RandomFractals
Copy link
Contributor Author

@tanhakabir oh, somehow I missed that part in docs and have not tried to just load a simple google.com page. will give it a go. Thanks!

@RandomFractals
Copy link
Contributor Author

RandomFractals commented Apr 29, 2021

nope. I get raw html that is not even formatted:

image

oh, you mean I have to click on </> and pick a built-in html renderer? probably need to update docs for this part:

image

@RandomFractals
Copy link
Contributor Author

RandomFractals commented Apr 29, 2021

also, looks like styles on nb cell and nb view page are not cleared and overiden by the loaded page:

image

Expected white google page render background in that cell output and retaining dark plus theme for the nb view ;)

i.e. should be rendered in iframe. I don't even know how that bg color got flipped there.

@jrieken are we using same dom for loading cell output styles, etc. as the main nb view?

@RandomFractals
Copy link
Contributor Author

also, note that google branding logo image did not load in that built-in html mime type output renderer :(

@tanhakabir
Copy link
Owner

probably need to update docs for this part

👍

@tanhakabir
Copy link
Owner

also, looks like styles on nb cell and nb view page are not cleared and overidden by the loaded page

This looks like a bug and not intentional! Creating an issue for that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants