Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#559 separate line doesn't display in dark mode #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MasterKali06
Copy link

@MasterKali06 MasterKali06 commented Mar 20, 2022

Description

it was a sass mini misconfig ..


had same color as background in dark.scss
created a new variable and give that a color
you can change the color to proper one later

Closes #559

Browser checklist

This PR has been tested in the following browsers:

  • Chrome
  • Firefox

Testing checklist

  • End-to-end tests have been created if necessary

Copy link

@NriotHrreion NriotHrreion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,5 +1,6 @@
$dark-sidebar: #333;
$dark-editor: #3f3f3f;
$dark-seperator: #777777;
Copy link

@leonardodimarchi leonardodimarchi Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be "dark-separator" 🤔 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] separate line doesn't display in dark mode
4 participants