Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow-cljs: Advanced build bloated since 6.0.3 #366

Closed
DerGuteMoritz opened this issue Jan 12, 2023 · 6 comments
Closed

shadow-cljs: Advanced build bloated since 6.0.3 #366

DerGuteMoritz opened this issue Jan 12, 2023 · 6 comments
Assignees
Labels

Comments

@DerGuteMoritz
Copy link
Contributor

DerGuteMoritz commented Jan 12, 2023

A shadow-cljs-based CLJS build grew from 512K to 630K between versions 6.0.2 and 6.0.3 (and persists in 6.0.4) with advanced optimizations. I was able to further narrow down the cause to com.taoensso/encore by switching to 6.0.2 and overriding its encore version. Turns out that encore version 3.34.0 is the last one that produces a 512K build. Versions 0.35.0 through 0.37.x are broken (due to #364) and version 0.38.0 and later then produce the bloated 630K build.

@DerGuteMoritz
Copy link
Contributor Author

I just tried with the following overrides to the respective latest versions:

{com.taoensso/encore {:mvn/version "3.45.0"}
 com.taoensso/truss {:mvn/version "1.8.0"}}

Still produces the same result.

@ptaoussanis ptaoussanis self-assigned this Jan 12, 2023
@ptaoussanis
Copy link
Member

@DerGuteMoritz Hi Moritz, thanks for reporting this - and for the clear & detailed report - was very helpful!

Would you please try [com.taoensso/encore "3.46.0-alpha1"] and let me know if that's also producing the bloated build?

@DerGuteMoritz
Copy link
Contributor Author

DerGuteMoritz commented Jan 12, 2023

Hi Peter, thanks for the swift reply 👍 Unfortunately, [com.taoensso/encore "3.46.0-alpha1"] doesn't make a difference (I double-checked that it's indeed being used).

@ptaoussanis
Copy link
Member

ptaoussanis commented Jan 12, 2023

👍 Is [com.taoensso/encore "3.46.0-alpha2"] any better?

If that's still no good, I'll try create a reproducible example on my side.

Thanks!

@DerGuteMoritz
Copy link
Contributor Author

Ha, that did the trick, down to 513K now 🎉 Nice work!

@ptaoussanis
Copy link
Member

Just pushed [com.taoensso/encore "3.46.0"] to Clojars 👍
Thanks so much for reporting this, apologies for the trouble!

Fix: taoensso/encore@9be0d41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants