Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faucet is incompatible with latest tap-parser #21

Open
jtlapp opened this issue Aug 4, 2016 · 2 comments
Open

Faucet is incompatible with latest tap-parser #21

jtlapp opened this issue Aug 4, 2016 · 2 comments

Comments

@jtlapp
Copy link

jtlapp commented Aug 4, 2016

Faucet is currently configured to use tap-parser version 0.4.0. The latest version is 1.2.2, but faucet has several compatibility issues with it.

I can get it to run without crashing if I change res.number to res.id in the assert event handler, but the output is all messed up.

I discovered this in the process of investigating why faucet wasn't properly handing my TAP "Bail out!" notice. The reason is that it uses a tap-parser that does not emit bailout.

@jtlapp
Copy link
Author

jtlapp commented Aug 5, 2016

My pending PR #20 gives faucet support for TAP bail outs without having to revise faucet to support the latest tap-parser.

@jtlapp
Copy link
Author

jtlapp commented Aug 31, 2016

I now see why you never upgraded faucet to the latest tap-parser. I have written a faucet-like runner for tap. It's called subtap. I had to reconstruct all the found/wanted value differences from the new event output. Lots of work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant