Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add proxy allow without authentication #47

Closed
mjtrangoni opened this issue Mar 4, 2024 · 2 comments · Fixed by #49
Closed

Feature request: Add proxy allow without authentication #47

mjtrangoni opened this issue Mar 4, 2024 · 2 comments · Fixed by #49

Comments

@mjtrangoni
Copy link
Contributor

Hi @tarampampam,

First of all, thank you for this project!

I would like to build something like,

env:
WEBPROXYALLOW="* * *api.letsencrypt.org,*.azure.com,*.microsoftonline.com"
WEBPROXYDENY="*"

resulting to a 3proxy.cfg like this,

allow * * *api.letsencrypt.org,*.azure.com,*.microsoftonline.com
deny *

as this currently not possible, I would like to ask you what would be your preferred way of building it? Should we build it in the authentication part or just make it separately afterwards?

Thank you!

@tarampampam
Copy link
Owner

Hello @mjtrangoni! I've added support for the additional environment variable named EXTRA_CONFIG (commit: 4f60889), so now you should be able to customize the configuration according to your needs!

Release: https://github.com/tarampampam/3proxy-docker/releases/tag/v1.9.0

@mjtrangoni
Copy link
Contributor Author

mjtrangoni commented Mar 26, 2024

@tarampampam I gave the new image a try, and it seems that order is critical here. As you can see, EXTRA_CONFIG comes at the very end, and it does not allow nor block anything at all. My proposal would be to move it before the proxy line.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants