Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow change default shard func #247

Closed
R-omk opened this issue Dec 6, 2021 · 2 comments
Closed

Allow change default shard func #247

R-omk opened this issue Dec 6, 2021 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@R-omk
Copy link

R-omk commented Dec 6, 2021

By default CRUD calculates bucket ID using primary key and a function vshard.router.bucket_id_strcrc32(key),

In addition to adding the ability to change the shard function, it should be explained to new users why using the default value (strcrc32) is a bad idea.
@Totktonada Totktonada added documentation Improvements or additions to documentation teamE labels Dec 6, 2021
@Totktonada
Copy link
Member

@R-omk Good idea, I would do it in the scope of #237.

BTW, do you know effects aside of ones described here, about which we should warn users?

@Totktonada Totktonada mentioned this issue Dec 6, 2021
Closed
@Totktonada
Copy link
Member

#237 is implemented and released in crud 0.11.0. The guides are in the readme. Feel free to reopen the issue if you think we should add something here.

@Totktonada Totktonada added duplicate This issue or pull request already exists and removed documentation Improvements or additions to documentation labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Totktonada @R-omk