Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dishonest schema reload timeout #320

Open
DifferentialOrange opened this issue Aug 26, 2022 · 0 comments
Open

Dishonest schema reload timeout #320

DifferentialOrange opened this issue Aug 26, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@DifferentialOrange
Copy link
Member

There is a problem with this timeout:

local function call_reload_schema(replicasets)
    for _ = 1,replicasets_num do
        if channel:get(const.RELOAD_SCHEMA_TIMEOUT) == nil then
            for _, f in ipairs(fibers) do
                if fiber:status() ~= 'dead' then
                    f:cancel()
                end
            end
            return nil, ReloadSchemaError:new("Reloading schema timed out")
        end
    end
...
end

replicasets_num * const.RELOAD_SCHEMA_TIMEOUT may require much more time than const.RELOAD_SCHEMA_TIMEOUT

Originally posted by @oleg-jukovec in #319 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants