Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operation convert is broken for splice #397

Open
DifferentialOrange opened this issue Nov 17, 2023 · 2 comments
Open

Update operation convert is broken for splice #397

DifferentialOrange opened this issue Nov 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@DifferentialOrange
Copy link
Member

tarantool> box.info.version
---
- 1.10.15-0-ge14d0b4
...

tarantool> crud.update('customers', 1, {{":", "name", 2, 3, "a"}})
---
- null
- line: 177
  class_name: UpdateError
  err: 'Failed to update: Unknown UPDATE operation'
  file: ./crud/update.lua
  str: 'UpdateError: Failed to update: Unknown UPDATE operation'
...

yet it is actually supported by Tarantool 1.10.15. The reason is that the operation is converted to invalid [[":",3,2]] operation:

crud/crud/common/utils.lua

Lines 776 to 778 in 48f801c

table.insert(converted_operations, {
operation[1], field_id, operation[3]
})

@DifferentialOrange DifferentialOrange added the bug Something isn't working label Nov 17, 2023
@DifferentialOrange
Copy link
Member Author

This one is likely to be closed together with 1.10 support drop

@oleg-jukovec
Copy link
Contributor

We need to remove a skip helper from the go-tarantool tests after the fix: tarantool/go-tarantool#353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants