Skip to content

[2pt] fiber.cond():wait() throws an error if fiber is cancelled #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #3063
TarantoolBot opened this issue Dec 2, 2020 · 1 comment
Open
Tracked by #3063
Labels
feature A new functionality fiber reference [location] Tarantool manual, Reference part

Comments

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Dec 2, 2020

fiber.cond():wait() throws an arror if fiber is cancelled

Product: Tarantool
Since: 2.7.1, 2.6.2, 2.5.3, 1.10.9
Audience/target:
Root document: https://www.tarantool.io/en/doc/latest/reference/reference_lua/fiber/#lua-function.cond_object.wait
SME: @sergos
Peer reviewer: @

Details

Currently fiber.cond():wait() throws an error if waiting fiber is
cancelled.
Requested by @sergos in tarantool/tarantool@bd03dfc.

See more details in the issue comments.

@Totktonada
Copy link
Member

I would ask to explicitly document the behaviour difference explicitly: prior the x.y.z.r version is it so (exclusive), after the version x.y.z.r it is so. The new behaviour is in action in the following tarantool versions:

  • All 1.10 since 1.10.8-27-g8fa32f9d4.
  • All 2.5 since 2.5.2-37-gbe7120796.
  • All 2.6 since 2.6.1-65-g64422754b.
  • All 2.7 since 2.7.0-76-gbd03dfc76.
  • All 2.8+.

The old behaviour is kept for the following versions:

  • All versions below 1.10.8-27-g8fa32f9d4 (exclusive).
  • All 2.1*, 2.2*. 2.3*, 2.4*.

Otherwise, if someone will be hit by the difference in the behaviour, it may be nightmare to spot a reason.

In the relevant email I gave an example of this kind (not ideal, though).

@Onvember Onvember added feature A new functionality reference [location] Tarantool manual, Reference part S (small) labels Feb 11, 2021
@Onvember Onvember changed the title fiber.cond():wait() throws if fiber is cancelled [6pt] fiber.cond():wait() throws if fiber is cancelled Feb 12, 2021
@NickVolynkin NickVolynkin changed the title [6pt] fiber.cond():wait() throws if fiber is cancelled [2pt] fiber.cond():wait() throws if fiber is cancelled Mar 10, 2021
@veod32 veod32 added server [area] Task relates to Tarantool's server (core) functionality 2.7.1 labels Mar 18, 2021
@veod32 veod32 changed the title [2pt] fiber.cond():wait() throws if fiber is cancelled [2pt] fiber.cond():wait() throws an error if fiber is cancelled Mar 18, 2021
@veod32 veod32 added this to the Tarantool releases of Dec 2020 milestone Mar 22, 2021
@veod32 veod32 removed 2.7.1 labels Feb 3, 2022
@patiencedaur patiencedaur mentioned this issue Aug 4, 2022
10 tasks
@veod32 veod32 added fiber and removed server [area] Task relates to Tarantool's server (core) functionality 2sp labels Mar 1, 2023
@veod32 veod32 removed this from the fiber milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality fiber reference [location] Tarantool manual, Reference part
Projects
None yet
Development

No branches or pull requests

6 participants