Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude 'flatten' file from coverage by default #190

Closed
yngvar-antonsson opened this issue Nov 3, 2021 · 3 comments
Closed

Exclude 'flatten' file from coverage by default #190

yngvar-antonsson opened this issue Nov 3, 2021 · 3 comments

Comments

@yngvar-antonsson
Copy link
Contributor

tarantool/crud produce 'flatten' file while flattening.

crud.insert_object('space', obj)
.rocks/bin/luatest integration_api --coverage
.rocks/bin/luacov .
Couldn't open flatten: No such file or directory

I propose to exclude it from coverage collection by default:

exclude = {
	'flatten',
}
@Totktonada
Copy link
Member

tarantool/crud does not create any temporary files. I think you're about the following code:

flatten_func = assert(load(code, '@flatten', 't', env))

https://github.com/tarantool/crud/blob/5e8c91e39bd608804e0ab85989a537dfd63ec7bf/crud/common/utils.lua#L116

See lunarmodules/luacov#55 (comment).

It seems, we should not use @ here. I guess that the best options is to leave it nil to make equal to code, see docs here and here.

@Totktonada
Copy link
Member

Filed tarantool/crud#249 against crud.

@ylobankov
Copy link
Member

Looks like not a luatest issue. So closing it. Feel free to reopen if it is related to luatest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants