Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename default metrics #117

Closed
yngvar-antonsson opened this issue Sep 18, 2020 · 5 comments · Fixed by #338
Closed

Rename default metrics #117

yngvar-antonsson opened this issue Sep 18, 2020 · 5 comments · Fixed by #338
Assignees
@yngvar-antonsson
Labels
bug Something isn't working refactoring Code refactoring

Comments

@yngvar-antonsson
Copy link
Collaborator

Prometheus have some problems with suffixes '_count' and '_total' for non-summary and non-histogram metrics
@vasiliy-t
Copy link
Contributor

image

@yngvar-antonsson
Copy link
Collaborator Author

https://gitlab.cncf.ci/prometheus/prometheus/commit/1faf33acacd28161ef8019e6beac68a10e524bfb

@github-actions
Copy link

github-actions bot commented Dec 8, 2020

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Dec 8, 2020
@yngvar-antonsson yngvar-antonsson added the bug Something isn't working label Dec 28, 2020
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Feb 26, 2021
@yngvar-antonsson yngvar-antonsson added refactoring Code refactoring and removed Stale labels Mar 1, 2021
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Apr 30, 2021
@yngvar-antonsson yngvar-antonsson mentioned this issue Jan 17, 2022
Merged
2 tasks
@yngvar-antonsson yngvar-antonsson self-assigned this Jan 17, 2022
@DifferentialOrange DifferentialOrange mentioned this issue Feb 3, 2022
Closed
@DifferentialOrange DifferentialOrange mentioned this issue Aug 3, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngvar-antonsson yngvar-antonsson

Labels
bug Something isn't working refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename default metrics tarantool/metrics
2 participants
@vasiliy-t @yngvar-antonsson