Propagate client thumbstone when a client creation fails

Closes: #30

Author: nicktorwald

src/main/java/org/tarantool/TarantoolClientImpl.java

@@ -28,9 +28,6 @@
 
 public class TarantoolClientImpl extends TarantoolBase<Future<?>> implements TarantoolClient {
 
-    public static final CommunicationException NOT_INIT_EXCEPTION
-        = new CommunicationException("Not connected, initializing connection");
-
     protected TarantoolClientConfig config;
     protected long operationTimeout;
 
@@ -101,7 +98,6 @@ public TarantoolClientImpl(SocketChannelProvider socketProvider, TarantoolClient
     }
 
     private void initClient(SocketChannelProvider socketProvider, TarantoolClientConfig config) {
-        this.thumbstone = NOT_INIT_EXCEPTION;
         this.config = config;
         this.initialRequestSize = config.defaultRequestSize;
         this.operationTimeout = config.operationExpiryTimeMillis;
@@ -130,8 +126,8 @@ private void startConnector(long initTimeoutMillis) {
                 CommunicationException e = new CommunicationException(
                     initTimeoutMillis +
                         "ms is exceeded when waiting for client initialization. " +
-                        "You could configure init timeout in TarantoolConfig"
-                );
+                        "You could configure init timeout in TarantoolConfig",
+                    thumbstone);
 
                 close(e);
                 throw e;
@@ -147,7 +143,7 @@ protected void reconnect(Throwable lastError) {
         int retryNumber = 0;
         while (!Thread.currentThread().isInterrupted()) {
             try {
-                channel = socketProvider.get(retryNumber++, lastError == NOT_INIT_EXCEPTION ? null : lastError);
+                channel = socketProvider.get(retryNumber++, lastError);
             } catch (Exception e) {
                 closeChannel(channel);
                 lastError = e;

src/test/java/org/tarantool/ClientReconnectIT.java

@@ -27,6 +27,7 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicReference;
 import java.util.concurrent.atomic.AtomicReferenceArray;
 import java.util.concurrent.locks.LockSupport;
 
@@ -412,13 +413,59 @@ public void testReconnectWrongAuth() throws Exception {
         client.close();
     }
 
-    private TestSocketChannelProvider makeZeroLingerProvider() {
+    @Test
+    void testFirstConnectionRefused() {
+        String errorText = "Fake error";
+        RuntimeException error = new RuntimeException(errorText);
+        TarantoolClientConfig config = makeDefaultClientConfig();
+        config.initTimeoutMillis = 100;
+        CommunicationException exception = assertThrows(
+            CommunicationException.class,
+            () -> new TarantoolClientImpl(makeErroredProvider(error), config)
+        );
+        Throwable wrapped = exception.getCause();
+        Throwable origin = wrapped.getCause();
+        assertEquals(errorText, wrapped.getMessage());
+        assertEquals(error, origin);
+    }
+
+    @Test
+    void testConnectionRefusedAfterConnect() {
+        TarantoolClientImpl client = new TarantoolClientImpl(makeErroredProvider(null), makeDefaultClientConfig());
+        client.ping();
+
+        testHelper.stopInstance();
+        CommunicationException exception = assertThrows(CommunicationException.class, client::ping);
+
+        Throwable origin = exception.getCause();
+        assertEquals(origin, client.getThumbstone());
+
+        testHelper.startInstance();
+    }
+
+    private SocketChannelProvider makeZeroLingerProvider() {
         return new TestSocketChannelProvider(
             TarantoolTestHelper.HOST, TarantoolTestHelper.PORT, RESTART_TIMEOUT
         ).setSoLinger(0);
     }
 
-    TarantoolClient makeClient(SocketChannelProvider provider) {
+    private SocketChannelProvider makeErroredProvider(RuntimeException error) {
+        return new SocketChannelProvider() {
+            private final SocketChannelProvider delegate = makeZeroLingerProvider();
+            private AtomicReference<RuntimeException> errorReference = new AtomicReference<>(error);
+
+            @Override
+            public SocketChannel get(int retryNumber, Throwable lastError) {
+                RuntimeException rawError = errorReference.get();
+                if (rawError != null) {
+                    throw rawError;
+                }
+                return delegate.get(retryNumber, lastError);
+            }
+        };
+    }
+
+    private TarantoolClient makeClient(SocketChannelProvider provider) {
         return new TarantoolClientImpl(provider, makeDefaultClientConfig());
     }