Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: improve integration test #957

Open
dmyger opened this issue Sep 25, 2024 · 0 comments
Open

tests: improve integration test #957

dmyger opened this issue Sep 25, 2024 · 0 comments
Labels
3sp code health Improve code readability, simplify maintenance and so on flaky test The issue describes the problem with the test being flaky python Pull requests that update Python code

Comments

@dmyger
Copy link
Collaborator

dmyger commented Sep 25, 2024

Suggestion: move methods start_app() and stop_app() in common utilities for integration tests.
Also, it would be useful to use Python class with destructor __exit__(self, ...) to catch and stop running instance of testing application.

See also kill_remain_processes_wrapper() method at tt/test/integration/connect/test_connect.py it kills a lot of stuck watchdog processes:
/tmp/pytest-of-runner/pytest-0/tt_build0/tt --cfg /tmp/pytest-of-runner/pytest-0/cartridge_app0/tt.yaml start --watchdog cartridge_app:***. So stopping the app should down such processes as well, too.

@dmyger dmyger added python Pull requests that update Python code flaky test The issue describes the problem with the test being flaky labels Sep 25, 2024
@oleg-jukovec oleg-jukovec added code health Improve code readability, simplify maintenance and so on 3sp labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3sp code health Improve code readability, simplify maintenance and so on flaky test The issue describes the problem with the test being flaky python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

2 participants