Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TARDIS setup and package infrastructure #1216

Closed
wkerzendorf opened this issue Jul 1, 2020 · 3 comments
Closed

Update TARDIS setup and package infrastructure #1216

wkerzendorf opened this issue Jul 1, 2020 · 3 comments

Comments

@wkerzendorf
Copy link
Member

TARDIS's setup and package architecture is based on theastropy's excellent package template ( https://github.com/astropy/package-template) this has changed in the last years and we should update our infrastructure to follow the new guidelines. We should also look out for this https://github.com/astropy/astropy-APEs/blob/master/APE17.rst. Once things are changed we need to add these files to be excluded from codestyle black changes.

@epassaro
Copy link
Member

epassaro commented Jan 23, 2021

Some considerations:

  • Maybe would be nice to implement it before on carsus since it's a smaller package to learn how it works
  • tardis still have montecarlo Cython code included (is this the only compiled extension, right?). Would be nice to ditch this before moving to new astropy template
  • Moving to the new template should be done before moving on conda-forge (or any form of packaging) otherwise we will doing the same job twice

25/01/2021

  • Also I found the new template uses setuptools_scm. This package allows setting versions according to git tags. This seems very conveniently, but unfortunately has some caveats. For example, it does not work if tags have the dev word on it. This would break our CI release cycle because our tags have the word dev.

@epassaro
Copy link
Member

epassaro commented Jun 3, 2021

Already moved carsus to the new package infrastructure, this could be done soon.

@epassaro epassaro mentioned this issue Jun 29, 2021
16 tasks
@epassaro
Copy link
Member

epassaro commented Jul 2, 2021

Closed by #1674

@epassaro epassaro closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants