Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Validation Documentation is Outdated #1593

Open
DhruvSondhi opened this issue May 28, 2021 · 0 comments
Open

Configuration Validation Documentation is Outdated #1593

DhruvSondhi opened this issue May 28, 2021 · 0 comments

Comments

@DhruvSondhi
Copy link
Contributor

DhruvSondhi commented May 28, 2021

Describe the bug
While working on the Config Validation PR, #1554, I was constantly referring to the documentation present for the same here. Following the abstract written, I found out that the section of the documentation pertaining to the keywords & the types is invalid & redundant. The current JSON Schema implementation done in TARDIS doesn't support the types stated in that particular section. This needs to be updated & rethought upon.
The current implementation also doesn't allow for quantity object comparison (through the schema) & hence specific functions were created in the mentioned PR. allowed_value, allowed_type are not parsed correctly in the schema.

@DhruvSondhi DhruvSondhi added the bug Something isn't working label May 28, 2021
@isaacgsmith isaacgsmith added documentation bug 🐞 and removed bug Something isn't working labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants