Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w never greater than 1 in level populations? #65

Closed
wkerzendorf opened this issue Dec 4, 2013 · 1 comment
Closed

w never greater than 1 in level populations? #65

wkerzendorf opened this issue Dec 4, 2013 · 1 comment
Assignees
Milestone

Comments

@wkerzendorf
Copy link
Member

is that right?

this line level_populations[~self.atom_data.levels.metastable] *= np.min([self.ws, np.ones_like(self.ws)],axis=0) in plasma_array. worth checking

@ghost ghost assigned ssim Dec 4, 2013
@ssim
Copy link
Contributor

ssim commented Jan 27, 2014

In the context of the approximation being made, I don't think it makes much sense to allow W>1 (this will lead to odd behaviour of populations that are "not metastable" compared to those that are "metastable). Better to limit to W <1 - perhaps flag a warning (likely means that the radiation field model is doing a particularly bad job).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants