Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a simple NewBlockTemplate that creates a block template and inserts the coinbase in one -- one sided coinbase #4419

Closed
stringhandler opened this issue Aug 8, 2022 · 3 comments
Labels
A-base_node Area - The Tari base node executable and libraries A-miner Area - SHA3 miner S-low-severity Severity - low

Comments

@stringhandler
Copy link
Collaborator

The current 2 step process of creating a block template is inefficient and means that there could be a delay for miners. Mining nodes that have implemented a better get_template will win more blocks, so it should be as efficient as possible

@SWvheerden
Copy link
Collaborator

The biggest issue we have here is the private key.
We need some unique key generation here.
Either

  • we need to send over a private key with grpc
  • add in a default wallet to call from the base_node
  • add a built-in wallet to the base node
  • provide the seed key so the base node can construct the correct key.

@SWvheerden
Copy link
Collaborator

SWvheerden commented Aug 10, 2022

If the Miner can calculate the MMR roots, then we can do it in a single call.
Problem with this however is that to calculate new MMR roots, the miner needs a copy of the entire pruned set of the MMR.

@stringhandler stringhandler added A-base_node Area - The Tari base node executable and libraries S-low-severity Severity - low A-miner Area - SHA3 miner labels Nov 15, 2022
@SWvheerden
Copy link
Collaborator

This is very much solved by make the coinbase transactions one-sided.

We can use two methods on this: normal 1-sided or even stealth-1-sided.
We can only use the HW wallet method as per RFC 205 -> tari-project/rfcs#98

@SWvheerden SWvheerden changed the title Create a simple NewBlockTemplate that creates a block template and inserts the coinbase in one Create a simple NewBlockTemplate that creates a block template and inserts the coinbase in one -- one sided coinbase Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-base_node Area - The Tari base node executable and libraries A-miner Area - SHA3 miner S-low-severity Severity - low
Projects
Status: Done
Development

No branches or pull requests

2 participants