New landing page #37

leostera · 2024-09-19T02:04:13Z

Not much to see here yet, just started drafting this page.

Moved us to MLX so its easier to see the final output of the page, and started using the dev preview to build this website. Works great!

The workflow is pretty annoying, since I have to run a while true; do dune exec sandworm -- ...; done and a separate server, and then manually reload the browser on every change.

This would be super smooth with something like astro.build but I want to honor the code we've written in OCaml so far – HOWEVER, there's a few things that'd be a lot better if we reused from JS world, like live-reloaders for styles.

I'm also using tailwind css.

This is based off the designs from Claire, with some content/structure adjustments based off Go's and Bun's websites.

Ref: https://www.figma.com/design/vSRUcQqOVTmRZqF1tD2Ov5/Dune-Download-Website?node-id=11-3&node-type=frame&t=LFqNbmPvTj45pZVv-0

leostera · 2024-09-19T02:04:55Z

Also yes I am quite jetlagged.

leostera · 2024-09-19T13:32:39Z

Some more changes here:

assume all releases have commit + certificate, we don't really care about older ones
add a install script based off bun.sh
prioritize a quick start but still show how to manually install + verify
make room for a FAQ section

leostera · 2024-09-19T13:33:50Z

Updated screenshot:

sandworm/lib/metadata.ml

leostera · 2024-09-19T14:05:17Z

sandworm/lib/web1.mlll

I'll remove this file before we merge.

maiste

This is a first batch of review, I'll focus on the HTML and testing tomorrow 👍
I still believe we shouldn't push the dune.lock as it is not considered to be portable (in the current situation).

install

maiste · 2024-09-19T16:13:04Z

install

+install_dir=$HOME/.dune
+bin_dir=$install_dir/bin


question (general, blocking): Why not install it to ~/local/bin as many programs do? It would let you not having to touch the path :)

Cargo, bun, npm, yarn, and other tools use ~/.<toolname>/bin for this so it seems like a well-known pattern.

install

maiste · 2024-09-19T16:15:19Z

install

+case $(basename "$SHELL") in
+fish)
+    # Install completions, but we don't care if it fails
+    IS_dune_AUTO_UPDATE=true SHELL=fish $exe completions &>/dev/null || :


I may be mistaken, but I don't thunk we have completion, no?

Ah yes, remnants from the original bun.sh install script :D will remove.

todo (blocking): remove the completion part to avoid script error.

maiste · 2024-09-19T16:26:40Z

install

+
+echo
+
+case $(basename "$SHELL") in


question (ux, non-blocking): Instead of directly exporting, what do you think about asking the user? It would prevent people that tries to install the newer version to have the export multiple times and also change the location for the people who want. WDYT?

sandworm/lib/metadata.ml

sandworm/sandworm.opam

yarn.lock

sandworm/dune-project

sandworm/.gitignore

maiste · 2024-09-20T08:49:48Z

suggestion (ui,non-blocking): For the header, what do you think about adding more margin to the left and to the right, as in ocaml.org? It's definitely an aesthetic question, though.

maiste

And here is the second round about the web page 😸

sandworm/lib/web.mlx

maiste · 2024-09-20T08:54:41Z

sandworm/lib/web.mlx

+      <pre>
+"
+$ dune init proj hello_world
+$ cd hello_world
+$ dune pkg lock
+$ dune exec hello_world
+"
+      </pre>


issue (ux,non-blocking): For the sake of readability, I would add a background to this. Uniformity is good, and you already put a gray background to the curl cmd.

Do you thing we should extract this to figma?

maiste · 2024-09-20T08:57:15Z

sandworm/lib/web.mlx

+let faq () =  
+  <section id="faq" class_="flex flex-col py-10 gap-2">
+    <h2 class_="text-3xl font-black pb-4"> "Frequently Asked Questions" </h2>
+  </section>


thought (non-blocking): One answer we can put it is the fact that they are unstable. It's most to protect us against any unsatisfied user 😄

sandworm/lib/web.mlx

Co-authored-by: Etienne Marais <dev@maiste.fr>

christinerose

LGTM!

maiste · 2024-09-24T08:50:32Z

suggestion (blocking): I don't see any problem with using our own dune to build the website. However, I would suggest that we do it in another PR, related to the CI. It would make the diff much cleaner for the future, and the PR less heavy. Thus, my suggestion is to remove the dune.lock and reintroduce it later.

I have pushed two more commits to fix small stuffs as you suggested 👍

+ feedback on copying command by swapping icons + limit release list to ~10 + fix background of getting started commands

maiste

Pair programming with @leostera to solve and merge this 👍

draft

636d039

draft install script from bun.sh/install

55bd0a5

leostera force-pushed the new-landing-page branch 2 times, most recently from b5df3c1 to 5ce70cc Compare September 19, 2024 13:28

first draft almost done

24b762d

leostera force-pushed the new-landing-page branch from 5ce70cc to 24b762d Compare September 19, 2024 13:29

leostera added 2 commits September 19, 2024 15:51

remove and ignore devtools locks

6536fac

fix typo in install script

8a06e04

leostera marked this pull request as ready for review September 19, 2024 13:59

leostera commented Sep 19, 2024

View reviewed changes

sandworm/lib/metadata.ml Show resolved Hide resolved

leostera commented Sep 19, 2024

View reviewed changes

sandworm/lib/web1.mlll Outdated

Copy link

Member Author

leostera Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this file before we merge.

maiste reviewed Sep 19, 2024

View reviewed changes

maiste reviewed Sep 20, 2024

View reviewed changes

leostera and others added 3 commits September 20, 2024 16:58

Update sandworm/lib/web.mlx

4540ec2

Co-authored-by: Etienne Marais <dev@maiste.fr>

Update sandworm/lib/web.mlx

345a324

Update sandworm/lib/web.mlx

42702c3

christinerose approved these changes Sep 24, 2024

View reviewed changes

maiste added 2 commits September 24, 2024 10:54

fix: extract title

e9c34cd

fix: move date in bundle

90c999d

christinerose approved these changes Sep 24, 2024

View reviewed changes

leostera added 5 commits September 25, 2024 14:35

remove autocomplete installs since we don't have any

f4d9cd2

fix: error on unsupported OS/Arch

114fda5

regen html

e446402

remove locks for now

a56df96

unify gitignores

bd9b89c

leostera added 3 commits September 25, 2024 14:59

fix links

cb94681

reintroduce plausible

b43c724

many things

810f61c

+ feedback on copying command by swapping icons + limit release list to ~10 + fix background of getting started commands

leostera force-pushed the new-landing-page branch from db9d582 to 810f61c Compare September 25, 2024 13:25

maiste added 4 commits September 25, 2024 15:28

remove old file

283a230

Update Link

1a1ba01

regenerate index

3a8adfc

Merge branch 'main' into new-landing-page

813eae3

maiste approved these changes Sep 25, 2024

View reviewed changes

maiste merged commit 300233d into main Sep 25, 2024

maiste deleted the new-landing-page branch September 25, 2024 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New landing page #37

New landing page #37

leostera commented Sep 19, 2024

leostera commented Sep 19, 2024

leostera commented Sep 19, 2024

leostera commented Sep 19, 2024

leostera Sep 19, 2024

maiste left a comment

maiste Sep 19, 2024 •

edited

Loading

leostera Sep 25, 2024

maiste Sep 19, 2024

leostera Sep 20, 2024

maiste Sep 23, 2024

maiste Sep 19, 2024 •

edited

Loading

maiste commented Sep 20, 2024 •

edited

Loading

maiste left a comment

maiste Sep 20, 2024 •

edited

Loading

maiste Sep 20, 2024 •

edited

Loading

christinerose left a comment

maiste commented Sep 24, 2024 •

edited

Loading

maiste left a comment

		install_dir=$HOME/.dune
		bin_dir=$install_dir/bin


		echo

		case $(basename "$SHELL") in

New landing page #37

New landing page #37

Conversation

leostera commented Sep 19, 2024

leostera commented Sep 19, 2024

leostera commented Sep 19, 2024

leostera commented Sep 19, 2024

leostera Sep 19, 2024

Choose a reason for hiding this comment

maiste left a comment

Choose a reason for hiding this comment

maiste Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

leostera Sep 25, 2024

Choose a reason for hiding this comment

maiste Sep 19, 2024

Choose a reason for hiding this comment

leostera Sep 20, 2024

Choose a reason for hiding this comment

maiste Sep 23, 2024

Choose a reason for hiding this comment

maiste Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

maiste commented Sep 20, 2024 • edited Loading

maiste left a comment

Choose a reason for hiding this comment

maiste Sep 20, 2024 • edited Loading

Choose a reason for hiding this comment

maiste Sep 20, 2024 • edited Loading

Choose a reason for hiding this comment

christinerose left a comment

Choose a reason for hiding this comment

maiste commented Sep 24, 2024 • edited Loading

maiste left a comment

Choose a reason for hiding this comment

maiste Sep 19, 2024 •

edited

Loading

maiste Sep 19, 2024 •

edited

Loading

maiste commented Sep 20, 2024 •

edited

Loading

maiste Sep 20, 2024 •

edited

Loading

maiste Sep 20, 2024 •

edited

Loading

maiste commented Sep 24, 2024 •

edited

Loading