Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might deselect too much after interrupt #50

Closed
blueyed opened this issue Nov 17, 2016 · 3 comments
Closed

Might deselect too much after interrupt #50

blueyed opened this issue Nov 17, 2016 · 3 comments

Comments

@blueyed
Copy link
Contributor

blueyed commented Nov 17, 2016

I've just seen that testmon deselect all items, after I've canceled the test run using KeyboardInterrupt.

I am using pytest-sugar also, and it was at 9% at that time.

Test session starts (platform: linux, Python 3.5.2, pytest 3.0.3, pytest-sugar 0.7.1)
cachedir: .cache
Django settings: velodrome.settings (from environment variable)
testmon=True, changed files: 17, skipping collection of 0 items, run variant: 60332d2767d943a82bceab2bffc7c6ea
…
^C

The next run deselected all items then:

      Test session starts (platform: linux, Python 3.5.2, pytest 3.0.3, pytest-sugar 0.7.1)
cachedir: .cache
Django settings: velodrome.settings (from environment variable)
testmon=True, changed files: 0, skipping collection of X items, run variant: 60332d2767d943a82bceab2bffc7c6ea
rootdir: …
plugins: xdist-1.15.dev9+ngba35a3d, catchlog-1.2.2, notifier-0.3, incremental-0.4.2, instafail-0.3.0, sugar-0.7.1, testmon-0.8.3, django-3.0.1.dev3+ngf18a858, random-0.2, asyncio-0.5.0, repeat-0.4.1, cov-2.4.0, mock-1.2, profiling-1.1.1, pdb-0.1.0, pylama-7.1.0, bpdb-0.1.4

==================================================== X tests deselected =====================================================

Results (0.14s):
     X deselected

I fear that this might be caused by f53d879 (or something else from the PR (#47)).

@tarpas
Copy link
Owner

tarpas commented Nov 20, 2016

I agree the PR #47 is a suspect but I didn't find out why, even after some exploration and thinking about it. It shouldn't be too difficult to write a unit test for it, so that would be a next step. Or should we revert the PR? How much do you need the feature?

@blueyed
Copy link
Contributor Author

blueyed commented Nov 20, 2016

How much do you need the feature?

Not more than being on the save side of not ignoring too much.. ;)
So feel free to revert it for now, but I agree that a test for this would be the best - from there it would be easy to bisect.

@tarpas
Copy link
Owner

tarpas commented Dec 8, 2016

https://github.com/tarpas/pytest-testmon/tree/refactor addresses saving intermediate design. We'll definitely revert the PR #47 stuff . And see.

@tarpas tarpas mentioned this issue Dec 8, 2016
@tarpas tarpas closed this as completed in 252d1e4 Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants