Skip to content
This repository has been archived by the owner on Feb 27, 2020. It is now read-only.

Wrap SandboxBuilder, Sandbox and ResultSet before passing to plugins #224

Open
jonasfj opened this issue Apr 1, 2017 · 1 comment
Open

Comments

@jonasfj
Copy link
Contributor

jonasfj commented Apr 1, 2017

Before we pass SandboxBuilder, Sandbox and ResultSet to plugins we should wrap with a simple wrapper that captures panic in any calls...

We might also want to use this forbid (or make impossible via. type-system) certain methods like Sandbox.WaitForResult() which plugins have no business calling.. Or ResultSet.Dispose(), clearly plugins should be calling those, so maybe we should remove the methods from the interfaces...

@jonasfj
Copy link
Contributor Author

jonasfj commented Apr 3, 2017

These wrapper should also apply a reasonable timeout... If NewShell takes more than 15min we can assume the process has deadlocked..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant