try handling registry error gracefuly and see what happens

Author: lotas

changelog/Kd63czIOSqmtb38S_OmW_g.md

@@ -0,0 +1,5 @@
+audience: general
+level: patch
+---
+
+Add error handling for docker image release process.

infrastructure/tooling/src/build/tasks/monoimage.js

@@ -57,8 +57,14 @@ const generateMonoimageTasks = ({ tasks, baseDir, cmdOptions, credentials, logsD
 
       const imageLocal = (await dockerImages({ baseDir }))
         .some(image => image.RepoTags && image.RepoTags.indexOf(tag) !== -1);
-      const imageOnRegistry = await dockerRegistryCheck({ tag });
-      utils.status({ message: `Image does ${imageOnRegistry ? '' : 'not '} exist on registry` });
+
+      let imageOnRegistry;
+      try {
+        imageOnRegistry = await dockerRegistryCheck({ tag });
+        utils.status({ message: `Image does ${imageOnRegistry ? '' : 'not '} exist on registry` });
+      } catch (err) {
+        utils.status({ message: `Error fetching image on registry: ${err.message}` });
+      }
 
       const provides = {
         'monoimage-docker-image': tag,
@@ -120,7 +126,14 @@ const generateMonoimageTasks = ({ tasks, baseDir, cmdOptions, credentials, logsD
 
       const imageLocal = (await dockerImages({ baseDir }))
         .some(image => image.RepoTags && image.RepoTags.indexOf(tag) !== -1);
-      const imageOnRegistry = await dockerRegistryCheck({ tag });
+
+      let imageOnRegistry;
+      try {
+        imageOnRegistry = await dockerRegistryCheck({ tag });
+        utils.status({ message: `Image does ${imageOnRegistry ? '' : 'not '} exist on registry` });
+      } catch (err) {
+        utils.status({ message: `Error fetching image on registry: ${err.message}` });
+      }
       utils.status({ message: `Image does ${imageOnRegistry ? '' : 'not '} exist on registry` });
 
       const provides = {

infrastructure/tooling/src/utils/docker.js

@@ -225,11 +225,12 @@ exports.dockerImages = async ({ baseDir }) => {
  */
 exports.dockerRegistryCheck = async ({ tag }) => {
   const [repo, imagetag] = tag.split(/:/);
+
   try {
     // Access the registry API directly to see if this tag already exists, and do not push if so.
     const res = await got(`https://hub.docker.com/v2/repositories/taskcluster/${repo}/tags`, { responseType: 'json' });
     if (!res.body) {
-      throw new Error('invalid response from index.docker.io');
+      throw new Error('invalid response from hub.docker.com');
     }
     if (res.body.map(l => l.name).includes(imagetag)) {
       return true;