Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dist): include dist as part of files in package.json #4

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

roggervalf
Copy link
Contributor

@roggervalf roggervalf commented Nov 8, 2024

ref #3

@@ -8,6 +8,7 @@
"source": "./src/index.ts",
"scripts": {
"build": "tsc && tsc -p tsconfig-cjs.json",
"dry-run": "npm publish --dry-run",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful to validate which files are going to be published

@@ -36,11 +40,11 @@
"@commitlint/cli": "^19.4.1",
"@commitlint/config-conventional": "^19.4.1",
"@semantic-release/changelog": "^6.0.3",
"@semantic-release/commit-analyzer": "^13.0.0",
"@semantic-release/commit-analyzer": "^9.0.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be friendly while using node 18

Copy link
Contributor

@fgozdz fgozdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roggervalf roggervalf merged commit 7f5aa34 into main Nov 8, 2024
@roggervalf roggervalf deleted the fix-dist branch November 8, 2024 14:39
github-actions bot pushed a commit that referenced this pull request Nov 8, 2024
## [1.0.1](v1.0.0...v1.0.1) (2024-11-08)

### Bug Fixes

* **dist:** include dist as part of files in package.json ([#4](#4)) ref [#3](#3) ([7f5aa34](7f5aa34))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants