feat(repeatable): allow saving custom key #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
May 4, 2023
src/classes/repeat.ts
Outdated
| jobId?: string; | ||
| key?: string; | ||
| }) { | ||
| const checksum = key ? key : md5(`${name}${jobId || ''}${md5(namespace)}`); | ||
| return `repeat:${checksum}:${nextMillis}`; | ||
| // return `repeat:${jobId || ''}:${name}:${namespace}:${nextMillis}`; |
There was a problem hiding this comment.
Lets remove these out commented code as well 👍
src/interfaces/repeat-options.ts
Outdated
| @@ -10,6 +10,12 @@ export interface RepeatOptions extends Omit<ParserOptions, 'iterator'> { | |||
| * A repeat pattern | |||
| */ | |||
| pattern?: string; | |||
|
|
|||
| /** | |||
| * Custom repeatable key | |||
There was a problem hiding this comment.
Complete with more information, like why is this needed:
"Custom repeatable key. This is the key that holds the "metadata" of a given repeatable job. This key is normally auto-generated but it is sometimes useful to specify a custom key for easier retrieval of repeatable jobs."
JefferyHus
reviewed
May 4, 2023
src/classes/repeat.ts
Outdated
| ); | ||
| nextMillis: '', | ||
| namespace: repeatJobKey, | ||
| jobId: jobId || repeat.jobId, |
There was a problem hiding this comment.
I would recommend the use of a nullish coalescing operator jobId: jobId ?? repeat.jobId
src/classes/repeat.ts
Outdated
| jobId?: string; | ||
| key?: string; | ||
| }) { | ||
| const checksum = key ? key : md5(`${name}${jobId || ''}${md5(namespace)}`); |
There was a problem hiding this comment.
Same here
const checksum = key ?? md5(`${name}${jobId ?? ''}${md5(namespace)}`);
|
This feature is really needed for me and this pr is open for quite long. Is it still planned to support this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1822