fix(connection): require connection to be passed #2335
Conversation
roggervalf
changed the base branch from
master
to
feat/better-handling-of-queue-markers
roggervalf
changed the base branch from
feat/better-handling-of-queue-markers
to
master
roggervalf
changed the base branch from
master
to
feat/better-handling-of-queue-markers
roggervalf
merged commit 1867dd1
into
feat/better-handling-of-queue-markers
# [5.0.0](v4.17.0...v5.0.0) (2023-12-21) ### Bug Fixes * **connection:** require connection to be passed ([#2335](#2335)) ([1867dd1](1867dd1)) * **job:** revert console warn custom job ids when they represent integers ([#2312](#2312)) ([84015ff](84015ff)) * **python:** unify redis connection args for Queue and Worker ([#2282](#2282)) ([8eee20f](8eee20f)) * **worker:** throw error if connection is missing ([6491a18](6491a18)) ### Features * **job:** provide skipAttempt option when manually moving a job ([#2203](#2203)) ([0e88e4f](0e88e4f)) * **python:** use new queue markers ([b0a13e8](b0a13e8)) * **python:** use new queue markers ([4276eb7](4276eb7)) * **worker:** improved markers handling ([73cf5fc](73cf5fc)) * **worker:** improved markers handling ([0bac0fb](0bac0fb)) ### BREAKING CHANGES * **worker:** Markers use now a dedicated key in redis instead of using a special Job ID. * **worker:** Markers use now a dedicated key in redis instead of using a special Job ID.
|
The connection requirement is not optimized for NestJS integration (should I need to copy the connection for every worker in my app if it's already set in BullModule?) |
Same here |
Same. What's the recommended course of action here? |
|
same for me :) |
|
If you do not pass a connection it will use the local connection, so please can you explain how this requirement affects NestJS? |
|
(the reason for requiring the connection is to avoid bugs where the connection was indadvertedly left undefined so it used the local connection instead in production where there weren't any) |
|
NestJS does use types from bullmq, I already made a fix in nestjs nestjs/bull#1960, waiting for PR approval the problem with nestjs, is that connection type become required and not optional, even tho it works, it breaks code for people and there is no easy way in nestjs to pass a connection because in nestjs these types are used in decorators |
Yes, that is the reason this was introduced in a major release after more than 6 months of warnings that the option was deprecated. |
|
Let me explain the problem a little better: in NestJS, I set up the connection with the |
No description provided.