-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(retry-jobs): add marker when needed #2374
Conversation
@@ -264,7 +264,7 @@ describe('events', function () { | |||
{ name: 'test', data: { foo: 'baz' } }, | |||
]); | |||
|
|||
await delay(1000); | |||
await delay(2000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taking the opportunity to check if there are no more drained events in this test case
@@ -468,7 +468,7 @@ describe('queues', function () { | |||
}); | |||
|
|||
describe('when completed state is provided', () => { | |||
it('retries all completed jobs', async () => { | |||
it('retries all completed jobs', async function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a flaky test, but with the marker addition, it should be fixed
16285b7
to
beb63bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## [5.1.3](v5.1.2...v5.1.3) (2024-01-16) ### Bug Fixes * **retry-jobs:** add marker when needed ([#2374](#2374)) ([1813d5f](1813d5f))
No description provided.