Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(retry-jobs): add marker when needed #2374

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

roggervalf
Copy link
Collaborator

No description provided.

@@ -264,7 +264,7 @@ describe('events', function () {
{ name: 'test', data: { foo: 'baz' } },
]);

await delay(1000);
await delay(2000);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taking the opportunity to check if there are no more drained events in this test case

@@ -468,7 +468,7 @@ describe('queues', function () {
});

describe('when completed state is provided', () => {
it('retries all completed jobs', async () => {
it('retries all completed jobs', async function () {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a flaky test, but with the marker addition, it should be fixed

@roggervalf roggervalf force-pushed the fix-retry-jobs-marker branch from 16285b7 to beb63bd Compare January 12, 2024 06:09
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roggervalf roggervalf merged commit 1813d5f into master Jan 16, 2024
11 checks passed
@roggervalf roggervalf deleted the fix-retry-jobs-marker branch January 16, 2024 13:13
github-actions bot pushed a commit that referenced this pull request Jan 16, 2024
## [5.1.3](v5.1.2...v5.1.3) (2024-01-16)

### Bug Fixes

* **retry-jobs:** add marker when needed ([#2374](#2374)) ([1813d5f](1813d5f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants