fix(marker): differentiate standard and delayed markers #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
fix-differentiate-markers
branch
from
35fcf44 to
ad629c7
Compare
|
I guess there is more code coming with changes on how to react differently depending on the marker type right? |
|
Yeah I think so, I added some todos to double check some commands as well |
|
But this pr is only related to this case, it should be ready |
roggervalf
force-pushed
the
fix-differentiate-markers
branch
2 times, most recently
from
c3b499a to
9b5964c
Compare
roggervalf
force-pushed
the
fix-differentiate-markers
branch
3 times, most recently
from
50e1915 to
0ec77a7
Compare
roggervalf
force-pushed
the
fix-differentiate-markers
branch
from
0ec77a7 to
f939ea5
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2024
## [5.1.10](v5.1.9...v5.1.10) (2024-02-10) ### Performance Improvements * **marker:** differentiate standard and delayed markers (python) ([#2389](#2389)) ([18ebee8](18ebee8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a marker from a delayed job could override an existing marker from a standard job as both have the same member value, that cause that a worker picks the marker thinking that all the remaining jobs are in delayed status, so it wait the delay even having standard jobs. In order to avoid that we can just use a different member value for the delayed jobs and bzpopmin will pick the lower value (standard marker "0" with score 0) later it could pick marker "1" with delayed score