fix(flow): parent job cannot be replaced #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
fix-parent-cannot-be-replaced
branch
from
b1e081d
to
c962c08
Compare
manast
reviewed
Feb 11, 2024
src/classes/scripts.ts
Outdated
| @@ -444,6 +444,10 @@ export class Scripts { | |||
| return new Error( | |||
| `Lock mismatch for job ${jobId}. Cmd ${command} from ${state}`, | |||
| ); | |||
| case ErrorCode.ParentJobCannotBeReplaced: | |||
| return new Error( | |||
| `Parent job from job ${jobId} cannot be replaced. ${command}`, | |||
There was a problem hiding this comment.
The grammar does not seem to be correct here, this should be better: "The parent job of job ${jobId} cannot be replaced."
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
## [5.1.11](v5.1.10...v5.1.11) (2024-02-13) ### Bug Fixes * **flow:** parent job cannot be replaced (python) ([#2417](#2417)) ([2696ef8](2696ef8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while adding a duplicated job, we can replace the parent job if this job had one, while replacing a parent value, we will end with an orphan parent, we must throw an error in this case