Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redis-connection): close redis connection even when initializing #2425

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix(redis-connection): close redis connection even when initializing #2425

merged 1 commit into from
Feb 16, 2024

Conversation

manast
Copy link
Contributor

@manast manast commented Feb 14, 2024

Fixes #2385

roggervalf
roggervalf approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@roggervalf roggervalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@roggervalf roggervalf force-pushed the fix/close-redis-connection-if-queue-closed-before-connecting branch from d8c1f2e to 773b9a2 Compare February 16, 2024 04:46
@roggervalf roggervalf merged commit 1bc26a6 into master Feb 16, 2024
11 checks passed
@roggervalf roggervalf deleted the fix/close-redis-connection-if-queue-closed-before-connecting branch February 16, 2024 05:32
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
@semantic-release-bot
chore(release): 5.1.12 [skip ci]
5938664 
## [5.1.12](v5.1.11...v5.1.12) (2024-02-16)

### Bug Fixes

* **redis-connection:** close redis connection even when initializing ([#2425](#2425)) fixes [#2385](#2385) ([1bc26a6](1bc26a6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roggervalf roggervalf roggervalf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Redis connection not correctly closed (regression)
2 participants
@manast @roggervalf