fix(worker): consider block timeouts less than 50ms #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Feb 28, 2024
| if (member) { | ||
| return parseInt(score); | ||
| } | ||
| blockTimeout = this.blockingConnection.capabilities.canDoubleTimeout |
There was a problem hiding this comment.
Actually we must have a blockTimeout that is a positive integer. The reason being that a value of 0 represents infinity, and a negative number would yield an exception. So maybe 1ms would do it? i.e. replace 0.05 by 0.001
roggervalf
commented
Feb 29, 2024
| const blockDelay = blockUntil - Date.now(); | ||
| // when we reach the time to get new jobs | ||
| if (blockDelay < 1) { | ||
| return 0.001; |
There was a problem hiding this comment.
looks like it will be only needed when blockDelay is less than 1 when getting a marker from a delayed job, wdyt @manast
manast
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2450