fix(connection): ignore error when setting custom end status #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A bit confused about this change, why replacing the reject by a resolve? |
|
I am thinking that if there is some specific place where we need to ignore this error it would be more elegant to ignore it just in that place instead of inside waitUntilReady. |
|
yes, I'm still testing how to get rid of it |
roggervalf
changed the title
manast
approved these changes
Apr 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
## [5.5.1](v5.5.0...v5.5.1) (2024-04-03) ### Bug Fixes * **connection:** ignore error when setting custom end status ([#2473](#2473)) ([3e17e45](3e17e45))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.