fix(delayed): avoid using jobId in order to schedule delayed jobs #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
May 30, 2024
There was a problem hiding this comment.
I propose a different way to calculate the score for the delayed job in the ZSET by using ZCOUNT https://redis.io/docs/latest/commands/zcount/ using as range all the possible values that a delayed job could get within a timestamp, that is:
[timestamp * 4096, (timestamp + 1) * 4096]. The count + 1 would then be used as the jobCounter is used today.
roggervalf
changed the title
manast
reviewed
Jun 2, 2024
roggervalf
force-pushed
the
fix-move-to-delayed-job-counter
branch
from
229d5fc
to
84a1e89
Compare
roggervalf
force-pushed
the
fix-move-to-delayed-job-counter
branch
from
84a1e89
to
5401174
Compare
manast
approved these changes
Jul 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
## [5.8.6](v5.8.5...v5.8.6) (2024-07-11) ### Bug Fixes * **delayed:** avoid using jobId in order to schedule delayed jobs ([#2587](#2587)) (python) ([228db2c](228db2c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref OptimalBits/bull#2742