fix(job): consider changing priority to 0 #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
change-priority-0
branch
2 times, most recently
from
25fa8f6
to
8037e5a
Compare
roggervalf
force-pushed
the
change-priority-0
branch
from
8037e5a
to
218cc5c
Compare
manast
approved these changes
Jun 28, 2024
src/commands/changePriority-6.lua
Outdated
| readdJobWithNewPriority( prioritizedKey, markerKey, target, | ||
| KEYS[5], ARGV[4] == '1', priority, jobId, isPaused) | ||
| elseif rcall("LREM", target, -1, jobId) > 0 then | ||
| readdJobWithNewPriority( prioritizedKey, markerKey, target, |
There was a problem hiding this comment.
maybe easier to read with "reAddJobWithNewPriority", first time I saw it I thought it was a typo.
roggervalf
force-pushed
the
change-priority-0
branch
from
45bcb07
to
20e0886
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
## [5.8.3](v5.8.2...v5.8.3) (2024-06-28) ### Bug Fixes * **job:** consider changing priority to 0 ([#2599](#2599)) ([4dba122](4dba122))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.