fix(repeatable): avoid delayed job deletion if next job already existed #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
## [5.13.2](v5.13.1...v5.13.2) (2024-09-20) ### Bug Fixes * **repeatable:** avoid delayed job deletion if next job already existed ([#2778](#2778)) ([6a851c1](6a851c1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2744 as if a repeatable job is promoted and it's not removed after completion, we can readd same repeatable. This operation removes current delayed job, but after that we are adding a delayed job that have the same jobId, as a duplicate we just ignore to add a new delayed instance. We should validate that this job exists before removing it. ref #2776