Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker-thread): allow passing Worker Options #2791

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

roggervalf
Copy link
Collaborator

ref #1555

Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small formatting issue.

@@ -83,6 +86,7 @@ export class Child extends EventEmitter {
stdin: true,
stdout: true,
stderr: true,
...(this.opts.workerThreadsOptions?this.opts.workerThreadsOptions:{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not properly formatted, missing spaces.

@roggervalf roggervalf merged commit 6a1f7a9 into master Sep 30, 2024
10 checks passed
@roggervalf roggervalf deleted the support-worker-thread-options branch September 30, 2024 07:03
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
# [5.14.0](v5.13.2...v5.14.0) (2024-09-30)

### Features

* **worker-thread:** allow passing Worker options ([#2791](#2791)) ref [#1555](#1555) ([6a1f7a9](6a1f7a9))
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Oct 2, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [bullmq](https://bullmq.io/) ([source](https://github.com/taskforcesh/bullmq)) | dependencies | minor | [`5.13.2` -> `5.15.0`](https://renovatebot.com/diffs/npm/bullmq/5.13.2/5.15.0) |

---

### Release Notes

<details>
<summary>taskforcesh/bullmq (bullmq)</summary>

### [`v5.15.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.15.0)

[Compare Source](taskforcesh/bullmq@v5.14.0...v5.15.0)

##### Features

-   **worker-fork:** allow passing fork options ([#&#8203;2795](taskforcesh/bullmq#2795)) ([f7a4292](taskforcesh/bullmq@f7a4292))

### [`v5.14.0`](https://github.com/taskforcesh/bullmq/releases/tag/v5.14.0)

[Compare Source](taskforcesh/bullmq@v5.13.2...v5.14.0)

##### Features

-   **worker-thread:** allow passing Worker options ([#&#8203;2791](taskforcesh/bullmq#2791)) ref [#&#8203;1555](taskforcesh/bullmq#1555) ([6a1f7a9](taskforcesh/bullmq@6a1f7a9))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEwNi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/178
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants